Initial benchmarks scaffolding #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adinapoli Looks great! I'm back from travels mostly so can be a little more responsive. I'm happy to merge as is, or were you looking to flesh it out further first and iterate on this? |
|
Hey David!
My preference would be to merge this, in a way that it can be used as a
stepping stone for more benchmarks or simply as a testament of the current
state of the library. I'll of course commit to add more as I (hopefully)
work my way through my outstanding PRs and tickets ;)
…On 13 May 2017 1:11 am, "David Terei" ***@***.***> wrote:
@adinapoli <https://github.com/adinapoli> Looks great! I'm back from
travels mostly so can be a little more responsive. I'm happy to merge as
is, or were you looking to flesh it out further first and iterate on this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#45 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAa-sxPvIEKw7oho3TPe7W1OFB6xjRAdks5r5OcwgaJpZM4NP0ME>
.
|
|
Done! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @dterei ,
following upon our discussion on #42, I have scavenged issue #2 and fleshed out a barebone Criterion suite, reusing what was inside
Bench1.hsand in the linked GHC Trac ticket.Hopefully we could expand this rapidly with specific tests targeting
text& the other combinators. Let me know if you think this is a good start!Alfredo