This repository has been archived by the owner on Oct 7, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the HIE Bios #1126
Implement the HIE Bios #1126
Changes from 250 commits
b054fe9
3ff19ba
f163539
fac0e95
4231b0b
8fe05bb
3e907c8
ab595a0
94eaa52
0f0c250
671d5ef
19a106d
e001a1b
8cd96b1
5180d25
973d4a2
ed9fefa
4ec8a13
3b41a98
9e7af09
0f507e6
e132d54
5373788
b9ebbec
ca06bd6
4f886df
daf0be5
8e44c14
30fb1e7
5ab587c
40342a0
cd882b6
ca53013
6f905aa
a305239
580b188
2c8b51b
0438ac0
9c7365f
c5f7d28
775eca2
d25984c
2bd16d8
f5a0308
94c3bcf
092c7a2
805961d
0d3af55
2feab0a
c619b66
3d96c12
a78b6a3
1b1bf14
1cbae78
0bfd54f
fb61925
373a474
a112dbb
6d8bd90
65d700b
7eb37df
2e36879
c243b50
98d8668
e83022e
6d9df0f
0738eb4
4031ac6
03473c9
5a5648d
5e09ef9
9039bcf
e631b58
c401bb2
4ff9a38
df764c3
50f4fe9
1cc08c4
6df6c64
46a986a
52601c9
80270ff
f91070d
f41edf2
d7403d2
54becfd
07f1dcd
3fb0985
4c96f82
3f84a89
794aa9a
bc5ff6f
57737df
4afb084
3752ac9
a7ec5fc
568cca1
7fbacf7
db18602
dd9cbdd
15037a4
48d29b1
10355fe
fdb4696
3be0213
40b6073
2505e45
c1824ed
f9756db
87eb220
5642252
9e3a4e0
5b56c15
2f006c7
fa65724
4f61966
eb3d32e
48958d8
c52a982
2ff3893
8dae303
172a557
f561472
582ff05
1cf6ab7
3dcedf8
89f8d83
52940fb
26d0ddd
a1bac07
294c401
52b60ba
ae844a0
7def514
799bfd6
408b0b5
2fdcb3a
c41eed0
2ffb17e
b72e606
91a56b0
b28e944
c84b33f
ed6d66b
83c5090
cc40b6f
7e7bd1d
92add4e
c45714e
0517eaa
97e6617
b775f13
b4f2326
9ceec1e
4309653
9ee8156
232e7d6
e1da603
3ed7833
a19ff9c
4a80ec3
d79e033
6a9b727
52691a6
e3fa438
3bfd965
e0a30bf
d109948
e8b4bee
b0a01e7
9fc2dcc
73fcf4b
702a5f5
1ca4e0a
d228c02
523da4d
dc8dab1
714f42a
dcf81a1
3795616
532aa60
61b6ba8
d30d058
32a6739
c2e4bfc
c6e7f31
924de7c
d467264
a0296ae
58c4019
8c3c350
4c5308b
7541d1e
7c206de
c983469
4bd1e75
90e1444
7681038
e212df1
d3d8ac2
41b9cab
8701f8b
9f5ef1b
fea7271
62267a5
361f6ef
ec3d362
b0b0c95
16f2580
31209a6
9ce648a
a173297
25bcde6
43cf0d1
bc079e9
bd40ac3
03d9bf2
0d44704
3ff767e
0effcf4
305b2d5
67d0903
8e91d80
9819903
ae8aa22
b7dfd2b
1b9767d
8e0241c
49582c2
3476f19
1a05e42
501cb28
cd0d1eb
a79ec33
c5b8a4b
b1363df
c4c04ce
89fe99d
20255f2
84e645c
c94b45e
cd3cd02
c193254
df1ac8a
6cbadc7
5dfc446
6f1c220
8e9bb3d
58ac672
bfedd03
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably want to ignore any hie.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we automatically generate the hie.yaml files again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for the tests. The tests need a
hie.yaml
to configure the project context properly.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these still the right remotes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, we could look at DanielG c-h directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need an issue which details what to do to remove this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, we want to subsume
ghc-project-types
to make us independent of ghc-mod.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moreover, if we take
ghc-project-types
and turn it into its own project, we are almost ready to go to hackage.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did discuss that with @DanielG , he is happy for us to move it elsewhere, possibly as a sub-project inside haskell-ide-engine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the lightweight-cabal syntax here I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here it should show how to define multi-cradles. Mutli-Cabal version is a bit above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure this will work well with multi-cradle projects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It wont, we have to tackle it in hie-bios
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I manually tested and documented how I intend it to work in https://github.com/mpickering/haskell-ide-engine/blob/hie-bios/hie-plugin-api/Haskell/Ide/Engine/Cradle.hs#L256
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, this will work in a best effort manner, imo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add TODO here about configuring logging levels separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does it not do anything? Make an issue describing what needs to be done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would be in favour of removing these manual command line arguments in favour for LSP's
InitialiseParams.trace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of legacy reasons, we had two flags
--vomit
for ghc-mod and-d
for lsp stuff. However, now hie-bios is also using the same logging mechanism like haskell-lsp, and we set the loggers to the same level. So, We should not remove it right away, because lsp-clients might set--vomit
and otherwise, all lsp-clients for haskell need to be updated.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to the feature freeze, I would like to create an issue for this after merge. would that be ok @bubba?