Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flattenSCC1 :: SCC a -> NonEmpty a #987

Merged
merged 4 commits into from
Aug 3, 2024
Merged

Add flattenSCC1 :: SCC a -> NonEmpty a #987

merged 4 commits into from
Aug 3, 2024

Conversation

andreasabel
Copy link
Member

This gives a more precise type to the existing flattenSCC :: SCC a -> [a].
Closes #985.

This gives a more precise type to the existing `flattenSCC :: SCC a -> [a]`.
Closes #985.
@Bodigrim
Copy link
Contributor

Bodigrim commented Feb 2, 2024

This probably needs a changelog entry and @since pragma, but I don't know what's the policy here and which version number is supposed to be released next.

@andreasabel
Copy link
Member Author

This probably needs a changelog entry and @since pragma, but I don't know what's the policy here and which version number is supposed to be released next.

I can add that here once the decision has been taken to merge this PR!

@treeowl
Copy link
Contributor

treeowl commented Feb 4, 2024

Let's do it.

Not sure which release the new function `flattenSCC1` will go in.
I speculated 0.7.1.
@andreasabel
Copy link
Member Author

Ok, I added a since for 0.7.1.

I was a bit surprised to see master at 0.6.8 when it already contained the changes for 0.7.
According to the changelog, master also contains breaking changes which would require the next master release to be 0.8.

containers/src/Data/Graph.hs Show resolved Hide resolved
containers/src/Data/Graph.hs Show resolved Hide resolved
@andreasabel andreasabel requested a review from meooow25 July 30, 2024 08:59
@meooow25 meooow25 merged commit e5661a7 into master Aug 3, 2024
11 checks passed
@meooow25
Copy link
Contributor

meooow25 commented Aug 3, 2024

Thanks!

@meooow25 meooow25 deleted the flattenSCC1 branch August 3, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add flattenSCC1 : SCC vertex -> Data.List.NonEmpty.NonEmpty vertex
4 participants