Make IntMap split, splitLookup strict in the key #982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a change log entry please? What were you doing that led you to notice this? |
Currently, the key is ignored for an empty map. All IntMap and IntSet functions taking a key are strict in the key. This allows the Int to be unboxed.
meooow25
force-pushed
the
intmap-split-strict
branch
from
caf0d7e to
b540dd2
Compare
Done 👍
I have a structure that stores |
|
Awesome. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All IntMap and IntSet functions taking a key are strict in the key. This allows the Int to be unboxed.
This is technically a breaking change. Currently
split undefined empty = (empty, empty), but with this changesplit undefined empty = undefined.