Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to GHC 9.8.2 (nightly-2024-03-26) #16

Merged
merged 1 commit into from
Mar 30, 2024
Merged

Conversation

tbidne
Copy link
Contributor

@tbidne tbidne commented Feb 20, 2024

Thought I'd open this to get the ball rolling, though I understand if we want to wait until more packages are added.

General Notes

Dropped packages

With this PR the package count drops by about 200:

-- master
λ. grep == clc-stackage.cabal | wc -l
2876

-- this
λ. grep == clc-stackage.cabal | wc -l
2643

In particular, quite a few amazonka packages have dropped out, so perhaps we want to wait for that to be fixed before merging.

New system dependencies

There are a couple new system dependencies:

  • openssl (required by core-telemetry, cql-io)
  • primecount (required by primecount)

Excluded packages

Other than exes, of the new packages that appeared in this snapshot, I excluded:

  • cuda: Requires proprietary CUDA deps.
  • stack: Requires custom GHC to be on the PATH as it is used in TH. If this isn't considered too onerous I can add it.

Nix

@googleson78

There isn't too much that is new here, other than documenting why some system libs are needed.

The main change is having nixpkgs.follows = "ghc_nix/nixpkgs". I did this since we need the custom GHC to be built with the same glibc as the system libs. Because ghc.nix is a (the most?) popular way to build GHC with nix, it seems useful to make this relationship explicit. Case in point, I made this change after running into errors using a recent version of nixos-unstable here, as my ghc.nix built compiler was on an earlier glibc.

Note that ghc.nix's current nixpkgs is fairly old (September 2023).

@Bodigrim
Copy link
Collaborator

Thanks @tbidne! I think re-adding stack is worth it. And let's wait a bit longer for amazonka.

@Bodigrim
Copy link
Collaborator

@tbidne could you please regenerate it with the latest nightly? I'd like to go ahead with it.

@tbidne
Copy link
Contributor Author

tbidne commented Mar 26, 2024

Can do. Note the amazonka issue is still unresolved, though I suppose it probably makes more sense to update to GHC 9.8 now and update again later as necessary.

@Bodigrim
Copy link
Collaborator

Yeah, let's skip amazonka for now.

@tbidne tbidne changed the title Update to GHC 9.8.1 (nightly-2024-02-18) Update to GHC 9.8.1 (nightly-2024-03-26) Mar 27, 2024
@tbidne tbidne changed the title Update to GHC 9.8.1 (nightly-2024-03-26) Update to GHC 9.8.2 (nightly-2024-03-26) Mar 27, 2024
@tbidne
Copy link
Contributor Author

tbidne commented Mar 27, 2024

@Bodigrim I updated the package set. I'm about 30% of the way through building it, and it looks like we took on a couple more system dependencies (fftw and expat so far). If you don't mind waiting a day or so, I should have enough cpu cycles by then to get through everything.

@Bodigrim
Copy link
Collaborator

Bodigrim commented Mar 27, 2024

Thanks for working on this, much appreciated!

@tbidne tbidne force-pushed the ghc981 branch 2 times, most recently from 262c465 to c9875ce Compare March 29, 2024 04:03
New external dependencies (haskell -> dep):

- core-telemetry, cql-io -> openssl
- emd -> fftw
- primecount -> primecount
@tbidne
Copy link
Contributor Author

tbidne commented Mar 29, 2024

@Bodigrim Just finished. Everything built except for 3 packages: grisette, hw-json-simd, and sbv. I am confident these are nix problems (documented here), so this can be merged AFAICT.

@Bodigrim Bodigrim merged commit c91ca5b into haskell:master Mar 30, 2024
@Bodigrim
Copy link
Collaborator

Thanks a ton!

@tbidne
Copy link
Contributor Author

tbidne commented Mar 31, 2024

Thanks for merging!

@tbidne tbidne deleted the ghc981 branch March 31, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants