Explicit export lists for Main #9890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekosaur
approved these changes
Apr 14, 2024
mergify
bot
added
the
ready and waiting
|
Wow, we missed this! Will merge soon. |
ulysses4ever
added
the
merge delay passed
Lack of explicit export list can degrade performance. The Main module in particular should always have an explicit export list that contains just the main function.
Mikolaj
force-pushed
the
noughtmare-patch-1
branch
from
17464e1 to
7850b6b
Compare
ulysses4ever
removed
merge me
|
Need a changelog, perhaps. |
|
@noughtmare it was mentioned on Cabal's Matrix that it's unnatural to merge something that says "Draft" on it. Do you think it's ready? It is in my opinion (modulo changelog, which you could add but if not I can do that). |
|
I totally forgot about this. I was indeed probably thinking of the changelog and documentation when marking this as draft. Please merge if you think this is ready. |
noughtmare
changed the title
mergify
bot
added
ready and waiting
philderbeast
pushed a commit
to cabalism/cabal
that referenced
this pull request
Dec 2, 2024
* Explicit export lists for Main Lack of explicit export list can degrade performance. The Main module in particular should always have an explicit export list that contains just the main function. * add changelog --------- Co-authored-by: Artem Pelenitsyn <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lack of explicit export list can degrade performance. The Main module in particular should always have an explicit export list that contains just the main function.
Fixes #9889
Template Α: This PR modifies
cabalbehaviourInclude the following checklist in your PR: