-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for #9799 #9805
Add tests for #9799 #9805
Conversation
f3f9612
to
71de533
Compare
@grayjay pinging for your review. |
# Revision history for T9799 | ||
|
||
## 0.1.0.0 -- YYYY-mm-dd | ||
|
||
* First version. Released on an unsuspecting world. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could the changelogs be removed to simplify the test packages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still a few changelogs:
cabal-testsuite/PackageTests/NewFreeze/T9799a/repo/libA-0.1.0.0/CHANGELOG.md
cabal-testsuite/PackageTests/NewFreeze/T9799a/repo/libA-0.2.0.0/CHANGELOG.md
cabal-testsuite/PackageTests/NewFreeze/T9799b/repo/libA-0.1.0.0/CHANGELOG.md
cabal-testsuite/PackageTests/NewFreeze/T9799b/repo/libA-0.2.0.0/CHANGELOG.md
71de533
to
2611892
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've addressed your review @grayjay. Should be good to go now.
# Revision history for T9799 | ||
|
||
## 0.1.0.0 -- YYYY-mm-dd | ||
|
||
* First version. Released on an unsuspecting world. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
97b97d9
to
a85ed9b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This is ready, except for one comment.
a85ed9b
to
c0e745f
Compare
Done. Thanks @grayjay. |
Add tests for haskell#9799 about freeze qualifying all packages with 'any' constraint scope.
c0e745f
to
2c052b1
Compare
Add tests for #9799 about freeze qualifying all packages with 'any' constraint scope.