-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hurd: Enable using $ORIGIN in RPATH #9441
Conversation
I don't know what's up with RTD; it should be using ubuntu-22.04 which is supported. |
This PR very much does modify cabal behavior. |
Well, depends what you call "behavior". It does change the eventual output indeed, but only to actually fix what is produced, to align it on what is produced e.g. on Linux. So there is nothing to document for users etc. and the test is just "works as expected on GNU/Hurd". ATM the resulting output is just unusable for relocatable installs... |
If the patch changes the behavior from being unusable to being convenient, it still changes behavior. Please, pick the appropriate PR template the next time. At the very minimum, the PR needs needs a changelog file. Dear Cabal maintainers, please, abstain from approving PRs without changelogs. |
I have added a changelog.d file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@mergify refresh |
✅ Pull request refreshed |
GNU/Hurd fully supports RPATH and the $ORIGIN development, and we indeed want to use it for relocatable installations shipped in Debian GNU/Hurd.
haskell/cabal#9441 Debian-Bug: https://bugs.debian.org/1056305 Gbp-Pq: Name hurd-cabal-supportrpaths
haskell/cabal#9441 Debian-Bug: https://bugs.debian.org/1056305 Gbp-Pq: Name hurd-cabal-supportrpaths
GNU/Hurd fully supports RPATH and the $ORIGIN development, and we indeed want to use it for relocatable installations shipped in Debian GNU/Hurd.
Template Α: This PR modifies
cabal
behaviourInclude the following checklist in your PR: