Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hurd: Enable using $ORIGIN in RPATH #9441

Merged
merged 1 commit into from
Nov 16, 2023
Merged

hurd: Enable using $ORIGIN in RPATH #9441

merged 1 commit into from
Nov 16, 2023

Conversation

sthibaul
Copy link
Collaborator

@sthibaul sthibaul commented Nov 13, 2023

GNU/Hurd fully supports RPATH and the $ORIGIN development, and we indeed want to use it for relocatable installations shipped in Debian GNU/Hurd.

Template Α: This PR modifies cabal behaviour

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • [N/A] The documentation has been updated, if necessary.
  • [N/A] Manual QA notes have been included.
  • Tests have been added. (Ask for help if you don’t know how to write them! Ask for an exemption if tests are too complex for too little coverage!)

@geekosaur
Copy link
Collaborator

I don't know what's up with RTD; it should be using ubuntu-22.04 which is supported.

@ulysses4ever
Copy link
Collaborator

This PR does not modify cabal behaviour

This PR very much does modify cabal behavior.

@sthibaul
Copy link
Collaborator Author

sthibaul commented Nov 13, 2023

This PR does not modify cabal behaviour

This PR very much does modify cabal behavior.

Well, depends what you call "behavior". It does change the eventual output indeed, but only to actually fix what is produced, to align it on what is produced e.g. on Linux. So there is nothing to document for users etc. and the test is just "works as expected on GNU/Hurd". ATM the resulting output is just unusable for relocatable installs...

@ulysses4ever
Copy link
Collaborator

If the patch changes the behavior from being unusable to being convenient, it still changes behavior. Please, pick the appropriate PR template the next time.

At the very minimum, the PR needs needs a changelog file.

Dear Cabal maintainers, please, abstain from approving PRs without changelogs.

@sthibaul
Copy link
Collaborator Author

I have added a changelog.d file

Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sthibaul sthibaul added the merge me Tell Mergify Bot to merge label Nov 14, 2023
@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Nov 16, 2023
@ulysses4ever
Copy link
Collaborator

@mergify refresh

Copy link
Contributor

mergify bot commented Nov 16, 2023

refresh

✅ Pull request refreshed

GNU/Hurd fully supports RPATH and the $ORIGIN development, and we indeed
want to use it for relocatable installations shipped in Debian GNU/Hurd.
@mergify mergify bot merged commit d063048 into haskell:master Nov 16, 2023
45 checks passed
raspbian-autopush pushed a commit to raspbian-packages/ghc that referenced this pull request Sep 26, 2024
haskell/cabal#9441
Debian-Bug: https://bugs.debian.org/1056305


Gbp-Pq: Name hurd-cabal-supportrpaths
raspbian-autopush pushed a commit to raspbian-packages/ghc that referenced this pull request Nov 14, 2024
haskell/cabal#9441
Debian-Bug: https://bugs.debian.org/1056305


Gbp-Pq: Name hurd-cabal-supportrpaths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants