Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cabal-package.rst w.r.t standalone foreign libs #9320

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

Update cabal-package.rst w.r.t standalone foreign libs #9320

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions doc/cabal-package-description-file.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1326,6 +1326,7 @@ A typical stanza for a foreign library looks like
lib-version-info: 6:3:2

if os(Windows)
-- standalone *must* be used on Windows.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
-- standalone *must* be used on Windows.
-- standalone *must* be used on Windows. See (pkg-field:: options: foreign library option list)

no idea how to make that a link with rST.

options: standalone
mod-def-file: MyForeignLib.def

Expand Down Expand Up @@ -1356,8 +1357,7 @@ A typical stanza for a foreign library looks like
have any dependencies on other (Haskell) shared libraries; without
the ``standalone`` option the generated library would have dependencies
on the Haskell runtime library (``libHSrts``), the base library
(``libHSbase``), etc. Currently, ``standalone`` *must* be used on Windows
and *must not* be used on any other platform.
(``libHSbase``), etc. The ``standalone`` option *must* be used on Windows.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still does not say why this must be used on windows. I mean sure, we do not have dynamic linking on window (for Haskell libraries) at all! So if you do not pass standalone you end up with only the library you are building, but it lacks all the dependencies. (I think).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not say why because I did not know why. What you say sounds reasonable, perhaps we should do some tests.


.. pkg-field:: mod-def-file: filename

Expand Down
Loading