-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify to avoid a typo #9315
Simplify to avoid a typo #9315
Conversation
@ulysses4ever, we'll need the label tweak to get this one through, won't we, same as #9264? |
@philderbeast I'm surprised that no one has granted you permissions to manage labels. I'll fix it today. Thanks! |
@mergify refresh |
✅ Pull request refreshed |
@philderbeast, you have the rare and powerful Write access to the repo. while Triage suffices to add labels. Are you sure you can't add labels to your PRs? |
@Mikolaj I can add labels. Thanks for that privilege. |
@Mikolaj with no explicit permissions, I'm pretty sure you can't change labels even on your own PRs. |
Yes, it is. Write permission is enough to do that. Triage as well. No permission is not enough. I thought that you suggested above that no permission is supposed to be enough to change labels on your own PRs, which is not the case (I think). If you didn't suggest that, then I misread you, and I apologize. |
No, I didn't intend to suggest that. Phew, great, so we have a common understanding of how it's supposed to work. :) I'm just worried something is broken (or I'm misunderstanding github), given that @philderbeast had the Write permission for some time, but apparently was not able to change labels (or else, why @ulysses4ever needed to do that personally?). |
Oh, so I misread you in another way also: I didn’t get / know that @philderbeast had the permissions! In that case I can’t explain it in any way other than that the GitHub UI is confusing (I very much believe in that), and Phil missed the button. |
I can confirm that you can'[t add labels even on your own PRs if you don't have repo permissions of some kind. |
Good to know, but it's not the situation we are trying to understand, because Phil did have the permissions (at least since a few days ago, when I checked). |
I found a typo reading the test suite readme and ended up shortening a sentence to avoid it.