Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify to avoid a typo #9315

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

philderbeast
Copy link
Collaborator

I found a typo reading the test suite readme and ended up shortening a sentence to avoid it.

@ffaf1 ffaf1 changed the title Simplify to avoid an an typo Simplify to avoid a typo Oct 6, 2023
@ulysses4ever ulysses4ever added the merge me Tell Mergify Bot to merge label Oct 6, 2023
@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Oct 8, 2023
@philderbeast
Copy link
Collaborator Author

@ulysses4ever, we'll need the label tweak to get this one through, won't we, same as #9264?

Screen Shot 2023-10-27 at 6 28 43 AM

@ulysses4ever
Copy link
Collaborator

@philderbeast I'm surprised that no one has granted you permissions to manage labels. I'll fix it today. Thanks!

@ulysses4ever ulysses4ever added merge+no rebase and removed merge me Tell Mergify Bot to merge labels Oct 27, 2023
@ulysses4ever
Copy link
Collaborator

@mergify refresh

@mergify
Copy link
Contributor

mergify bot commented Oct 27, 2023

refresh

✅ Pull request refreshed

@mergify mergify bot merged commit 2df64b4 into haskell:master Oct 27, 2023
42 of 43 checks passed
@Mikolaj
Copy link
Member

Mikolaj commented Oct 27, 2023

@philderbeast, you have the rare and powerful Write access to the repo. while Triage suffices to add labels. Are you sure you can't add labels to your PRs?

@philderbeast
Copy link
Collaborator Author

@Mikolaj I can add labels. Thanks for that privilege.

@ulysses4ever
Copy link
Collaborator

@Mikolaj with no explicit permissions, I'm pretty sure you can't change labels even on your own PRs.

@Mikolaj
Copy link
Member

Mikolaj commented Oct 27, 2023

I'm missing something. Is this the label changing we are talking about?
image

@ulysses4ever
Copy link
Collaborator

Yes, it is. Write permission is enough to do that. Triage as well. No permission is not enough. I thought that you suggested above that no permission is supposed to be enough to change labels on your own PRs, which is not the case (I think). If you didn't suggest that, then I misread you, and I apologize.

@Mikolaj
Copy link
Member

Mikolaj commented Oct 27, 2023

No, I didn't intend to suggest that. Phew, great, so we have a common understanding of how it's supposed to work. :) I'm just worried something is broken (or I'm misunderstanding github), given that @philderbeast had the Write permission for some time, but apparently was not able to change labels (or else, why @ulysses4ever needed to do that personally?).

@ulysses4ever
Copy link
Collaborator

Oh, so I misread you in another way also: I didn’t get / know that @philderbeast had the permissions! In that case I can’t explain it in any way other than that the GitHub UI is confusing (I very much believe in that), and Phil missed the button.

@geekosaur
Copy link
Collaborator

I can confirm that you can'[t add labels even on your own PRs if you don't have repo permissions of some kind.

@Mikolaj
Copy link
Member

Mikolaj commented Oct 27, 2023

I can confirm that you can'[t add labels even on your own PRs if you don't have repo permissions of some kind.

Good to know, but it's not the situation we are trying to understand, because Phil did have the permissions (at least since a few days ago, when I checked).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge+no rebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants