Removing chooseSolver and inline Modular solver as default choice
#9282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
geekosaur
approved these changes
Sep 22, 2023
grayjay
approved these changes
Sep 22, 2023
|
That doesn't seem like a broken CI infrastructure, right? Just a warning turned into an error, probably coming from this PR? |
|
Yes, it looks like an import is unused after this change. |
yvan-sraka
force-pushed
the
simplify-choose-solver
branch
from
e1f9530 to
68ee8ff
Compare
Fixed :) |
mergify
bot
added
the
merge delay passed
Mikolaj
force-pushed
the
simplify-choose-solver
branch
from
68ee8ff to
e435054
Compare
andreabedini
force-pushed
the
simplify-choose-solver
branch
from
e435054 to
119c21b
Compare
|
Rebased as CI was broken |
|
🎉 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does not modify
cabalbehaviour (refactoring). Its purpose is too split #9206 into two!Include the following checklist in your PR: