*.project.* files use program-options to specify -fno-ignore-asserts

[ulysses4ever]

Simplifies *.project.* files a bit. It wasn't feasible before #7973, as program-options were applied to dependencies as well, which is undesirable.

This is undoing 0c99981, which was a stop-gap against #3911. #7973 should cover #3911 these days.

TODO:

• as mentioned in *.project.* files use program-options to specify -fno-ignore-asserts #8350 (comment), it requires CI to bump its cabal to 3.8

---

Please include the following checklist in your PR:

• Patches conform to the coding conventions.
• Any changes that could be relevant to users have been recorded in the changelog.
• The documentation has been updated, if necessary.

Please also shortly describe how you tested your change. Bonus points for added tests!

[ulysses4ever]

Hmm... it seems like the global program-options still hurt build time? CI was cancelled for reasons I don't understand, but the build time seems to be higher than on other jobs...

[Mikolaj]

Oh dear, this time CI failed on Linux, in a similar way.

[Mikolaj]

FYI: CI is borked right now (#8356), so the error probably has nothing to do with this PR.

[Mikolaj]

Let me rebase to see if the recent CI workaround unblocks merging.

[Mikolaj]

@mergify rebase

[mergify]

rebase

✅ Branch has been successfully rebased

[Mikolaj]

It fails differently now...

[ulysses4ever]

Right... My main concern right now is not failures but the gigantic running time of the succeeding jobs. This wasn't supposed to happen with #7973. Unless I'm missing something (like GHA caching).

[jneira]

I think the cause is ci is still using cabal 3.6.2.0, which does not include the change

[ulysses4ever]

Ooh, that makes sense, thank you! So this will have to sit until we decide to migrate CI to 3.8...

[ulysses4ever]

CI is at 3.8 now (afair), do maybe it's the prime time?..

[ulysses4ever]

@mergify rebase

[mergify]

rebase

❌ Base branch update has failed

Git reported the following error:

Rebasing (1/1)
error: could not apply e44377417... *.project.* files use program-options to specify -fno-ignore-asserts
Resolve all conflicts manually, mark them as resolved with
"git add/rm <conflicted_files>", then run "git rebase --continue".
You can instead skip this commit: run "git rebase --skip".
To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply e44377417... *.project.* files use program-options to specify -fno-ignore-asserts
Auto-merging cabal.project
CONFLICT (content): Merge conflict in cabal.project

err-code: 63F1C

[ulysses4ever]

All right, CI time is normal now (~22 mins per validate job), which means that program-options are applied only to local packages as expected. Ready for review!

[Mikolaj]

Thanks a lot!

[Mikolaj]

@mergify rebase

[mergify]

rebase

✅ Branch has been successfully rebased

[Mikolaj]

Ci looks like it may succeed, so let me take the liberty of setting the merge_me label.