Remove unused LANGUAGE pragmas #10634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philderbeast
force-pushed
the
hlint/unused-lang-pragma
branch
from
262d482 to
ea745c3
Compare
ulysses4ever
approved these changes
Dec 11, 2024
cabal-install/tests/UnitTests/Distribution/Solver/Modular/DSL.hs
Outdated
Show resolved
Hide resolved
- Avoid -Wname-shadowing - Use -XDisambiguateRecordFields as needed - Avoid -Wname-shadowing by importing qualified
philderbeast
force-pushed
the
hlint/unused-lang-pragma
branch
from
4bae177 to
fe4617f
Compare
|
Label merge+no rebase is necessary when the pull request is from an organisation. |
mergify
bot
added
ready and waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #9110, remove unused LANGUAGE pragmas.
I missed removing some LANGUAGE pragmas after moving code between modules. A reviewer noticed but this is something HLint can check for, #10554 (comment).
Changed a couple of local variable names to avoid
-Wname-shadowing(@sheaf these areactionPtranddepsRes) and added-XDisambiguateRecordFieldsin one place as HLint suggested to avoid[GHC-76037]when removing-XRecordWildCards.To avoid
-Xname-shadowingfor theincludesbinding inCabal/src/Distribution/Backpack/Configure.hs, I added an import list to the import ofDistribution.PackageDescription.To avoid
-Xname-shadowingincabal-install/src/Distribution/Client/Errors.hs, I imported a couple of modules qualified: