Have projects import trimmed URIs #10629
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulysses4ever
reviewed
Dec 9, 2024
|
Will need a changelog but otherwise it looks like the right direction overall. |
philderbeast
force-pushed
the
fix/project-untrimmed-url
branch
4 times, most recently
from
4ebca6f to
e27511e
Compare
geekosaur
approved these changes
Dec 9, 2024
|
Huh. First time I've seen RTD fail that way. |
And I didn't change the docs. @geekosaur, other CI jobs I can restart but not that one. |
|
That's normal, since RTD isn't actually part of GitHub Actions. You'll need to change something somewhere to trigger a new build, though. (You may want to hold off a bit though, to let RTD fix whatever's wrong on their end.) |
philderbeast
force-pushed
the
fix/project-untrimmed-url
branch
2 times, most recently
from
50b9a2e to
f719178
Compare
philderbeast
force-pushed
the
fix/project-untrimmed-url
branch
from
f719178 to
52978ba
Compare
|
@geekosaur I've included a W3C quote about URLs in the changelog and added the bug label to this pull request as it fixes a bug. |
philderbeast
force-pushed
the
fix/project-untrimmed-url
branch
from
ec5673e to
7fdca03
Compare
- Don't do any file path manipulations for URLs
- Use with-ghc.config trick
philderbeast
force-pushed
the
fix/project-untrimmed-url
branch
from
7fdca03 to
70e5317
Compare
philderbeast
force-pushed
the
fix/project-untrimmed-url
branch
from
3e644b1 to
6c087fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10622. Trims URIs before parsing them with
parseURI. If any project config path doesn't equal its trimmed self then it is displayed quoted so that the whitespace is obvious.Template Α: This PR modifies behaviour or interface
Include the following checklist in your PR:
significance: significantin the changelog file.cabal-testsuitetests.