Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have hlint ignore dist-* #10621

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Have hlint ignore dist-* #10621

merged 2 commits into from
Dec 9, 2024

Conversation

philderbeast
Copy link
Collaborator

@philderbeast philderbeast commented Dec 7, 2024 •
edited
Loading

For #10560, configure hlint to ignore dist-* folders. Also bump the hlint warnings counts (they're getting worse).

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

geekosaur
geekosaur approved these changes Dec 7, 2024
View reviewed changes
Copy link
Collaborator

@geekosaur geekosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't even bother with counts for some of them; as far as I'm concerned, they're hlint trying to impose someone else's coding style on me, and given they're in our .hlint.yml I'm apparently not alone.

@mergify mergify bot added the ready and waiting Mergify is waiting out the cooldown period label Dec 7, 2024
@philderbeast
Copy link
Collaborator Author

Label merge+no rebase is necessary when the pull request is from an organisation.

@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Dec 9, 2024
@mergify mergify bot merged commit e8d73a2 into haskell:master Dec 9, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffaf1 ffaf1 ffaf1 approved these changes

@geekosaur geekosaur geekosaur approved these changes

Assignees
No one assigned
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge+no rebase ready and waiting Mergify is waiting out the cooldown period
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philderbeast @geekosaur @ffaf1