Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try a rule to check for a PR template #10612

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

geekosaur
Copy link
Collaborator

@geekosaur geekosaur commented Dec 2, 2024

For now it checks for the first item, which is the same in both and should always be required (many of the others are arguable in various circumstances).

Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

For now it checks for the first item, which is the same in both
and should always be required (many of the others are arguable
in various circumstances).
@geekosaur
Copy link
Collaborator Author

geekosaur commented Dec 2, 2024

We probably want to look at #10575 / #10594 to decide what we really want to do with this, which is one reason I marked it as draft.

@geekosaur geekosaur added blocked: decision-needed re: devx Improving the cabal developer experience (internal issue) github_actions Pull requests that update GitHub Actions code labels Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked: decision-needed continuous-integration github_actions Pull requests that update GitHub Actions code re: devx Improving the cabal developer experience (internal issue)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant