-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: guide on profiling: fix the title #10606
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the file should be renamed as well….
@malteneuss Does this align with the vision you had for this guide? |
I would be a bit less succinct and say something like "How to configure a project for profiling" or "Configuring a project for profiling". But the current title is also fine for me, so I'll approve |
Thanks, I'm open for options. I am not a fan of the first because it's a little lengthy, and the second deviates from the pattern that's established in the guide section: everything starts from "How to" (maybe not a great decision but it should be applied or unapplied consistently). Let's see what @malteneuss and others has to say.
I was being lazy, sorry! Fixed. |
The title was chosen to be more beginner friendly and to be immediately understandable even when someone doesn't know the correct technical term "profiling", i.e. people who are more likely to need a guide. Imagine what you would search if you didn't know that term: probably "measure haskell performance" or similar. Still, the guide uses the term "profiling" enough times to be locatable via Google easily for someone who knows. While "analyze .. performance" isn't technically correct yet, (e.g. we don't explain how to to interpret results), that could be added later (even by just referencing the optimization book or GHC guide). It's also a relatively short title. Alternatives could have been "How to setup Cabal to measure Haskell performance" if it wasn't so long. |
Let's not get ahead of ourselves. Only when and if such an addition is implemented can we discuss a title that reflects that new content. Besides, @jasagredo and I argued that it's not Cabal Guide's job to teach people to interpret GHC profiles. So, I am doubtful that such an addition will even happen. Of course, others may rule otherwise.
I think Cabal Guide shouldn't be targeted at CS freshmen. The average reader is not very familiar with Haskell but is somewhat familiar with computer programming. So, I'd expect them to be aware of the notion of "profiling". How about:
for the title? |
(question for all) |
I'm in favor of:
|
Good enough for me |
Good enough for me too |
@ulysses4ever Is everything alright with this PR? It blocks haskell/blog.haskell.org#9 |
Oh, I totally forgot about it. Let's fast-track. |
This pull request has been removed from the queue for the following reason: Pull request #10606 has been dequeued. The pull request rule doesn't match anymore. The following conditions don't match anymore:
You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
Actually, after re-reading the thread: it needs one more fixup, which I can do later today |
@mergify rebase |
✅ Branch has been successfully rebased |
900c1c9
to
8c9f398
Compare
"Title underline too short." really??? |
Sounds like the Sphinx version of what I went through while trying to bend GHA to my will. |
* Docs: guide on profiling: fix the title * fixup! rename the file too * fixup! * fixup! --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Please read Github PR Conventions and then fill in one of these two templates.
Template B: This PR does not modify behaviour or interface
E.g. the PR only touches documentation or tests, does refactorings, etc.
Include the following checklist in your PR: