-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print info about current project file in use to stderr and ignore the imports by default #10548
Conversation
265403e
to
c81b238
Compare
Oh my, the two hundred tests now fail because |
I just ran
|
Okay, I figured how to print to stderr without reaching to I'm also fixing the above mentioned issue with multiple |
0136805
to
f2888ce
Compare
f2888ce
to
db8e6b4
Compare
I'm working on something similar (an alternative to #9933 that warns instead of errors), see branch fix/y-fork-project-import-warning-only. I've seen the loss of indent in those messages before and corrected it by changing from |
6ff627c
to
1ec2c25
Compare
in verbose mode report imported files too
1ec2c25
to
7f89bd0
Compare
All right, now it prints only top-level project config files in the default verbosity. In the verbose mode it prints the whole thing (imported project files too). The formatting of imports is not great but it's okay for verbose mode and can be fixed later if desired. |
@Kleidukos, #10507 (backported to 3.14) turned out severely undercooked. This PR fixes it for the most part. So, I hope it can be backported too. Otherwise, it’d be desirable to revert the backport of 10507. |
Sure, just put the correct labels to remind us to do the backports :) |
f96907b
to
e63ac8b
Compare
e63ac8b
to
e50b1e4
Compare
cf47f01
to
8c6e2aa
Compare
Co-authored-by: ffaf1 <[email protected]>
This fixes a regression on master that was backported to 3.14. In the interest of getting it into the release, I'm skipping the two-days delay. |
@mergify backport 3.14 |
✅ Backports have been created
|
… imports by default (#10548) * Print info about current project file in use to stderr (fix #10547) * only report top-level project config files in the default verbosity in verbose mode report imported files too * fix tests * don't print anything when provenance is empty * fix tests * Apply suggestions from code review Co-authored-by: ffaf1 <[email protected]> --------- Co-authored-by: ffaf1 <[email protected]> (cherry picked from commit 7de199a) # Conflicts: # cabal-testsuite/PackageTests/ConditionalAndImport/cabal.out
…rr and ignore the imports by default (#10550) * Print info about current project file in use to stderr and ignore the imports by default (#10548) * Print info about current project file in use to stderr (fix #10547) * only report top-level project config files in the default verbosity in verbose mode report imported files too * fix tests * don't print anything when provenance is empty * fix tests * Apply suggestions from code review Co-authored-by: ffaf1 <[email protected]> --------- Co-authored-by: ffaf1 <[email protected]> (cherry picked from commit 7de199a) # Conflicts: # cabal-testsuite/PackageTests/ConditionalAndImport/cabal.out * fixup! fix conflicts --------- Co-authored-by: Artem Pelenitsyn <[email protected]>
fix #10547 by printing the project config info to stderr.
Also, report only top-level project configs with the default verbosity. Otherwise, imported config files can still be seen in the verbose mode.
Manual Q/A
Try to reproduce #10547
Template Α: This PR modifies behaviour or interface
Include the following checklist in your PR:
Any changes that could be relevant to users have been recorded in the changelog.Is the change significant? If so, remember to addsignificance: significant
in the changelog file.