Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update the pinned index-state to get the new rere #10276

Merged
merged 1 commit into from
Aug 28, 2024
Merged

update the pinned index-state to get the new rere #10276

merged 1 commit into from
Aug 28, 2024

Conversation

geekosaur
Copy link
Collaborator

Without this, #10202 breaks cabal.project.release on ghc 9.10.1.

Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

@geekosaur geekosaur mentioned this pull request Aug 26, 2024
Open
2 tasks
@geekosaur
Copy link
Collaborator Author

Either we backport this, or we must revert #10208 on 3.12 (that's c9a6e25).

@ulysses4ever
Copy link
Collaborator

My vote is for backporting

@geekosaur
Copy link
Collaborator Author

I'm a bit wary of changing the expected dependencies for a release branch.

@geekosaur geekosaur added merge me Tell Mergify Bot to merge and removed attention: needs-review labels Aug 26, 2024
@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Aug 28, 2024
@geekosaur @Mikolaj
update the pinned index-state to get the new rere
be38526 
Without this, haskell#10202 breaks `cabal.project.release` on ghc 9.10.1.
@mergify mergify bot merged commit 9e586f8 into haskell:master Aug 28, 2024
49 checks passed
@geekosaur
Copy link
Collaborator Author

@mergify backport 3.12

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 30, 2024 •
edited
Loading

backport 3.12

✅ Backports have been created

@mergify mergify bot mentioned this pull request Aug 30, 2024
Merged
2 tasks
@geekosaur geekosaur deleted the index-state-rere branch August 30, 2024 21:12
mergify bot added a commit that referenced this pull request Sep 14, 2024
@mergify
Merge pull request #10296 from haskell/mergify/bp/3.12/pr-10276
b477def 
update the pinned index-state to get the new `rere` (backport #10276)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulysses4ever ulysses4ever ulysses4ever approved these changes

@Mikolaj Mikolaj Mikolaj approved these changes

Assignees
No one assigned
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@geekosaur @ulysses4ever @Mikolaj