Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Die if dynamic executable is requested on Windows #10217

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

jasagredo
Copy link
Collaborator

@jasagredo jasagredo commented Jul 19, 2024

Closes #9807

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • Manual QA notes have been included.
  • Tests have been added. (Ask for help if you don’t know how to write them! Ask for an exemption if tests are too complex for too little coverage!)

QA

Trying to build with --enable-executable-dynamic will now stop before attempting to compile.

Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. thanks!

Cabal/src/Distribution/Simple/Configure.hs Outdated Show resolved Hide resolved
@jasagredo jasagredo force-pushed the js/die-shared-exe-win branch from 827c188 to 11063a8 Compare July 22, 2024 21:39
@jasagredo jasagredo force-pushed the js/die-shared-exe-win branch from 11063a8 to 84fe6b5 Compare July 22, 2024 21:42
@jasagredo jasagredo marked this pull request as ready for review July 22, 2024 21:42
@jasagredo jasagredo requested a review from geekosaur July 22, 2024 21:42
@Kleidukos
Copy link
Member

@jasagredo can you update this wiki page with a short paragraph on the Windows situation? https://gitlab.haskell.org/ghc/ghc/-/wikis/Linking

Copy link
Collaborator

@geekosaur geekosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I'm an ideal reviewer given that I don't have a Windows install.

@jasagredo
Copy link
Collaborator Author

@jasagredo can you update this wiki page with a short paragraph on the Windows situation? https://gitlab.haskell.org/ghc/ghc/-/wikis/Linking

@Kleidukos I wish I could. I know that it doesn't work, but I don't know why it doesn't work 😄

@jasagredo jasagredo added the merge me Tell Mergify Bot to merge label Jul 22, 2024
@Kleidukos
Copy link
Member

@jasagredo curse. Send me the paragraph and I'll integrate it. :)

@jasagredo
Copy link
Collaborator Author

This is the only info I have https://gitlab.haskell.org/ghc/ghc/-/wikis/windows-dynamic-linking and maybe it is outdated, I don't know 😢

@jasagredo jasagredo removed the merge me Tell Mergify Bot to merge label Jul 22, 2024
@jasagredo jasagredo force-pushed the js/die-shared-exe-win branch from 84fe6b5 to 0b90f48 Compare July 23, 2024 21:19
@jasagredo jasagredo added the merge me Tell Mergify Bot to merge label Jul 24, 2024
@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Jul 26, 2024
@mergify mergify bot merged commit 5e6f306 into haskell:master Jul 26, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge
Projects
None yet
4 participants