-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Windows tests (backport #10186) #10211
Conversation
(cherry picked from commit e54d477)
(cherry picked from commit f8ab58c)
(cherry picked from commit d73af0d)
(cherry picked from commit f33929b) # Conflicts: # cabal-testsuite/src/Test/Cabal/OutputNormalizer.hs
(cherry picked from commit e290366) # Conflicts: # cabal-testsuite/src/Test/Cabal/Prelude.hs
(cherry picked from commit 83ec0b9)
(cherry picked from commit 3ccb534)
(cherry picked from commit 4b1d9b9) # Conflicts: # cabal-testsuite/PackageTests/Backpack/Includes2/setup-per-component.out # cabal-testsuite/PackageTests/HaddockKeepsTmps/cabal.test.hs # cabal-testsuite/PackageTests/NewFreeze/T9799b/src/None.hs # cabal-testsuite/PackageTests/ProfShared/setup.test.hs # validate.sh
Cherry-pick of f33929b has failed:
Cherry-pick of e290366 has failed:
Cherry-pick of 4b1d9b9 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Depends on #9900 which isn't being backported. |
@jasagredo, do you think there's a way to fix these for 3.12 without causing problems when 3.14 comes out? (Not that I think that should happen, since it will only involve |
* Fix ForeignLibs test for Windows (cherry picked from commit be1ae31) # Conflicts: # cabal-testsuite/PackageTests/ForeignLibs/setup.test.hs * try to build without #10211 * Swap it in the correct direction --------- Co-authored-by: Javier Sagredo <[email protected]> Co-authored-by: brandon s allbery kf8nh <[email protected]>
local+noindex
uri inwithRepo
which enables many tests on Windows (just a matter of\\ -> /
)\\ -> /
but also removingC:\\
)skip*IO
functions onIO ()
to quickly discard tests without having to setup a test env55 tests in total which were skipped or expected broken on Windows now are passing:
and
66-55=11
tests were previously being skipped and now are marked as known failure, with an issue number: