solver: Prevent ghc-internal from being reinstalled (see #10087) #10093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekosaur
approved these changes
Jun 9, 2024
18 tasks
ulysses4ever
approved these changes
Jun 9, 2024
ulysses4ever
added
squash+merge me
grayjay
approved these changes
Jun 10, 2024
|
CI has been broken and is now fixed, so let me rebase to restart it with the fixes included. |
|
@mergify rebase |
GHC 9.10 ships with a new wired-in package, ghc-internal, which cannot be reinstalled. This commit prevents cabal-install from attempting it.
✅ Branch has been successfully rebased |
Mikolaj
force-pushed
the
wip/non-reinstallable-ghc-internal
branch
from
be2e1c7 to
20d3a52
Compare
mergify
bot
added
the
merge delay passed
|
@mergify backport 3.12 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 13, 2024
) GHC 9.10 ships with a new wired-in package, ghc-internal, which cannot be reinstalled. This commit prevents cabal-install from attempting it. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit b1c8ee6)
5 tasks
mergify bot
added a commit
that referenced
this pull request
Jun 13, 2024
) (#10108) GHC 9.10 ships with a new wired-in package, ghc-internal, which cannot be reinstalled. This commit prevents cabal-install from attempting it. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit b1c8ee6) Co-authored-by: Adam Gundry <[email protected]>
erikd
pushed a commit
to erikd/cabal
that referenced
this pull request
Jun 17, 2024
… (haskell#10093) GHC 9.10 ships with a new wired-in package, ghc-internal, which cannot be reinstalled. This commit prevents cabal-install from attempting it. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
|
We missed a changelog entry on this PR, and this is a user-visible change. We should strive to do better next time. |
mmhat
pushed a commit
to mmhat/cabal
that referenced
this pull request
Jun 24, 2024
… (haskell#10093) GHC 9.10 ships with a new wired-in package, ghc-internal, which cannot be reinstalled. This commit prevents cabal-install from attempting it. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
tbidne
pushed a commit
to tbidne/cabal
that referenced
this pull request
Jul 3, 2024
… (haskell#10093) GHC 9.10 ships with a new wired-in package, ghc-internal, which cannot be reinstalled. This commit prevents cabal-install from attempting it. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GHC 9.10 ships with a new wired-in package,
ghc-internal, which cannot be reinstalled. This commit preventscabal-installfrom attempting it. See #10087.It would be good to include this alongside GHC 9.10 support, if possible.
QA Notes
Attempting to build a package called
ghc-internalthat has no dependencies should result in a dependency solving error "constraint from non-reinstallable package requires installed instance".