Remove upper bound on dlist (outdated) #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The predominant style seems to not have bounds, so I removed the upper bound rather than replacing it by < 1.1. The changes in dlist-1.0 (removal of eliminator `list`, change of `tail`) do not affect the use of dlist in `bytestring`, namely in the `test-builder` test-suite.
Bodigrim
approved these changes
Aug 31, 2021
|
Ha, this (trivial) issue got me involved more than I thought: See spl/dlist#98 and ddssff/listlike#14. |
|
Thanks! |
Bodigrim
pushed a commit
to Bodigrim/bytestring
that referenced
this pull request
Sep 12, 2021
noughtmare
pushed a commit
to noughtmare/bytestring
that referenced
this pull request
Dec 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove upper bound on
dlist(outdated).The predominant style seems to not have bounds, so I removed the upper bound rather than replacing it by < 1.1.
(Maintainers: check whether this is indeed within the spirit of this package.)
Build with the latest
dlist, dlist-1.0. The changes in dlist-1.0 (removal of eliminatorlist, change oftail) do not affect the use of dlist inbytestring, namely in thetest-buildertest-suite.