basic GitHub Actions; fix tests; GHC 9 still failing #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests are failing to build, but #21 might help |
|
One of the issues is simply a missing instance for |
|
To fix building with GHC 9, there are some dependencies which may need to be updated. For GHC 8, everything seems to be good now: https://github.com/peterbecich/servant-ekg/runs/4994048104?check_suite_focus=true |
peterbecich
changed the title
peterbecich
changed the title
|
Alright; shall we turn GHC 9 support into a new PR and merge tthis as is? |
arianvp
approved these changes
Jan 31, 2022
arianvp
reviewed
Jan 31, 2022
arianvp
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/peterbecich/servant-ekg/actions/runs/1738605018