Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H-3524: Remove wrong input parameters from terraform execute action #5514

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

TimDiekmann
Copy link
Member

🌟 What is the purpose of this PR?

type and options are not allowed as input.

@TimDiekmann TimDiekmann requested a review from CiaranMn October 29, 2024 08:52
@TimDiekmann TimDiekmann self-assigned this Oct 29, 2024
@github-actions github-actions bot added the area/infra Relates to version control, CI, CD or IaC (area) label Oct 29, 2024
Copy link
Contributor

Benchmark results

@rust/graph-benches – Integrations

representative_read_entity_type

Function Value Mean Flame graphs
get_entity_type_by_id Account ID: d4e16033-c281-4cde-aa35-9085bf2e7579 $$1.38 \mathrm{ms} \pm 4.81 \mathrm{μs}\left({\color{gray}-0.123 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_complete_zero_depth

Function Value Mean Flame graphs
entity_by_id 10 entities $$2.11 \mathrm{ms} \pm 11.7 \mathrm{μs}\left({\color{gray}-0.113 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 50 entities $$4.26 \mathrm{ms} \pm 40.3 \mathrm{μs}\left({\color{gray}2.39 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$1.86 \mathrm{ms} \pm 14.0 \mathrm{μs}\left({\color{gray}-0.238 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 5 entities $$1.88 \mathrm{ms} \pm 11.2 \mathrm{μs}\left({\color{gray}-1.169 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 25 entities $$3.33 \mathrm{ms} \pm 19.2 \mathrm{μs}\left({\color{red}20.4 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_linkless

Function Value Mean Flame graphs
entity_by_id 10 entities $$1.87 \mathrm{ms} \pm 5.74 \mathrm{μs}\left({\color{gray}-1.024 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1000 entities $$3.04 \mathrm{ms} \pm 9.80 \mathrm{μs}\left({\color{gray}2.19 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$1.85 \mathrm{ms} \pm 6.89 \mathrm{μs}\left({\color{gray}-1.258 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10000 entities $$9.33 \mathrm{ms} \pm 73.6 \mathrm{μs}\left({\color{gray}-0.410 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 100 entities $$2.03 \mathrm{ms} \pm 9.76 \mathrm{μs}\left({\color{gray}-2.022 \mathrm{\%}}\right) $$ Flame Graph

representative_read_multiple_entities

Function Value Mean Flame graphs
entity_by_property depths: DT=255, PT=255, ET=255, E=255 $$70.9 \mathrm{ms} \pm 390 \mathrm{μs}\left({\color{gray}-1.504 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=2, ET=2, E=2 $$57.1 \mathrm{ms} \pm 440 \mathrm{μs}\left({\color{gray}-0.983 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=0, E=0 $$42.6 \mathrm{ms} \pm 246 \mathrm{μs}\left({\color{gray}-1.058 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=2, E=2 $$52.3 \mathrm{ms} \pm 311 \mathrm{μs}\left({\color{gray}-0.067 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=0, E=2 $$46.9 \mathrm{ms} \pm 276 \mathrm{μs}\left({\color{gray}-1.721 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=2, PT=2, ET=2, E=2 $$60.7 \mathrm{ms} \pm 332 \mathrm{μs}\left({\color{gray}-2.328 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=255, PT=255, ET=255, E=255 $$110 \mathrm{ms} \pm 507 \mathrm{μs}\left({\color{gray}-1.607 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=2, ET=2, E=2 $$96.4 \mathrm{ms} \pm 496 \mathrm{μs}\left({\color{gray}-2.102 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=0, E=0 $$44.7 \mathrm{ms} \pm 317 \mathrm{μs}\left({\color{gray}-1.112 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=2, E=2 $$91.6 \mathrm{ms} \pm 488 \mathrm{μs}\left({\color{gray}-3.212 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=0, E=2 $$83.8 \mathrm{ms} \pm 495 \mathrm{μs}\left({\color{gray}-1.690 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=2, PT=2, ET=2, E=2 $$101 \mathrm{ms} \pm 722 \mathrm{μs}\left({\color{gray}-1.819 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_complete_one_depth

Function Value Mean Flame graphs
entity_by_id 10 entities $$52.2 \mathrm{ms} \pm 199 \mathrm{μs}\left({\color{red}62.3 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 50 entities $$277 \mathrm{ms} \pm 1.70 \mathrm{ms}\left({\color{lightgreen}-25.120 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$20.0 \mathrm{ms} \pm 147 \mathrm{μs}\left({\color{gray}-1.490 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 5 entities $$25.4 \mathrm{ms} \pm 122 \mathrm{μs}\left({\color{gray}-0.172 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 25 entities $$77.1 \mathrm{ms} \pm 435 \mathrm{μs}\left({\color{gray}1.80 \mathrm{\%}}\right) $$ Flame Graph

representative_read_entity

Function Value Mean Flame graphs
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/book/v/1 $$17.5 \mathrm{ms} \pm 215 \mathrm{μs}\left({\color{lightgreen}-5.967 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/building/v/1 $$16.8 \mathrm{ms} \pm 222 \mathrm{μs}\left({\color{gray}-3.274 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/block/v/1 $$17.5 \mathrm{ms} \pm 198 \mathrm{μs}\left({\color{gray}0.212 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/organization/v/1 $$17.3 \mathrm{ms} \pm 203 \mathrm{μs}\left({\color{gray}-0.092 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/uk-address/v/1 $$19.0 \mathrm{ms} \pm 224 \mathrm{μs}\left({\color{red}9.28 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/page/v/2 $$17.7 \mathrm{ms} \pm 232 \mathrm{μs}\left({\color{red}6.27 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/person/v/1 $$17.2 \mathrm{ms} \pm 215 \mathrm{μs}\left({\color{gray}-1.921 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/playlist/v/1 $$18.5 \mathrm{ms} \pm 228 \mathrm{μs}\left({\color{gray}0.873 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/song/v/1 $$17.4 \mathrm{ms} \pm 243 \mathrm{μs}\left({\color{gray}2.52 \mathrm{\%}}\right) $$ Flame Graph

Merged via the queue into main with commit 56fcecf Oct 29, 2024
163 of 164 checks passed
@TimDiekmann TimDiekmann deleted the t/h-3524-fix-linting-error-in-terraform-executor branch October 29, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/infra Relates to version control, CI, CD or IaC (area)
Development

Successfully merging this pull request may close these issues.

2 participants