Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust crate tarpc to v0.35.0 #5505

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Update Rust crate tarpc to v0.35.0 #5505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8256336
Update Rust crate `tarpc` to v0.35.0
hash-worker[bot] Oct 27, 2024
1294cea
Attempt to fix code
TimDiekmann Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
110 changes: 34 additions & 76 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ similar-asserts = { version = "=1.6.0", default-features = false }
supports-color = { version = "=3.0.1", default-features = false }
supports-unicode = { version = "=3.0.0", default-features = false }
tachyonix = { version = "=0.3.1", default-features = false }
tarpc = { version = "=0.33", default-features = false }
tarpc = { version = "=0.35.0", default-features = false }
temporal-io-client = { package = "temporal-client", git = "https://github.com/temporalio/sdk-core", rev = "7e3c23f" }
temporal-io-sdk-core-protos = { package = "temporal-sdk-core-protos", git = "https://github.com/temporalio/sdk-core", rev = "7e3c23f" }
test-fuzz = { version = "=6.0.0", default-features = false }
Expand Down
6 changes: 5 additions & 1 deletion apps/hash-graph/bins/cli/src/subcommand/type_fetcher.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,11 @@ pub async fn type_fetcher(args: TypeFetcherArgs) -> Result<(), GraphError> {
server
.load_predefined_types()
.expect("should be able to load predefined types");
channel.execute(server.serve())
channel
.execute(server.serve())
.for_each(|response| async move {
tokio::spawn(response);
})
})
.buffer_unordered(255)
.for_each(|()| async {})
Expand Down
2 changes: 1 addition & 1 deletion apps/hash-graph/libs/type-fetcher/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ description = "RPC service definition to fetch external BP types"
type-system = { workspace = true, public = true }

# Public third-party dependencies
tarpc = { workspace = true, public = true, features = ["tokio1"] }
time = { workspace = true, public = true, features = ["serde", "std"] }
serde_json = { workspace = true, public = true }

Expand All @@ -25,7 +26,6 @@ futures = { workspace = true }
include_dir = { workspace = true, features = ["glob"] }
reqwest = { workspace = true, features = ["json"] }
serde = { workspace = true, features = ["derive"] }
tarpc = { workspace = true, features = ["tokio1"] }
tracing = { workspace = true }

[lints]
Expand Down
2 changes: 2 additions & 0 deletions apps/hash-graph/libs/type-fetcher/src/fetcher.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#![expect(clippy::future_not_send)]

use core::{error::Error, fmt};

use serde::{Deserialize, Serialize};
Expand Down
1 change: 0 additions & 1 deletion apps/hash-graph/libs/type-fetcher/src/fetcher_server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ impl FetchServer {
}
}

#[tarpc::server]
impl Fetcher for FetchServer {
async fn fetch_ontology_types(
self,
Expand Down
Loading