Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ipMode field #2557

Draft
wants to merge 10 commits into
base: v3-major-release
Choose a base branch
from
Draft

Conversation

sheneska
Copy link
Contributor

@sheneska sheneska commented Jul 22, 2024

Description

Fixes #2471

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...
jaylon.mcshan@jaylon issue-testing % kubectl get svc test-lb -o yaml

apiVersion: v1
kind: Service
metadata:
  creationTimestamp: "2024-11-29T14:58:08Z"
  name: test-lb
  namespace: default
  resourceVersion: "57005"
  uid: d1894d2e-c6be-46b0-bfd5-76d39152c278
spec:
  allocateLoadBalancerNodePorts: true
  clusterIP: 10.96.43.23
  clusterIPs:
  - 10.96.43.23
  externalTrafficPolicy: Cluster
  internalTrafficPolicy: Cluster
  ipFamilies:
  - IPv4
  ipFamilyPolicy: SingleStack
  ports:
  - nodePort: 30142
    port: 80
    protocol: TCP
    targetPort: 80
  selector:
    app: test-app
  sessionAffinity: None
  type: LoadBalancer
status:
  loadBalancer:
    ingress:
    - ip: 192.168.1.100
      ipMode: VIP

Release Note

Release note for CHANGELOG:

...

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@sheneska sheneska requested a review from a team as a code owner July 22, 2024 21:27
@sheneska sheneska marked this pull request as draft July 22, 2024 21:36
@BBBmau BBBmau added the blocked label Aug 14, 2024
@BBBmau BBBmau added this to the v2.23.0 milestone Aug 14, 2024
@BBBmau BBBmau modified the milestones: v2.33.0, v3.0.0 Aug 29, 2024
@JaylonmcShan03 JaylonmcShan03 force-pushed the add-loadbalancer-status-support branch from fb06733 to 27608ca Compare November 19, 2024 00:51
@JaylonmcShan03 JaylonmcShan03 changed the base branch from main to v3-major-release November 19, 2024 00:51
@github-actions github-actions bot added size/M and removed size/S labels Nov 20, 2024
@github-actions github-actions bot added size/XL and removed size/M labels Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support .status.loadBalancer.ingress.ipMode in resource_kubernetes_service_v1.go
3 participants