Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for user custom attribute issues #173

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

AndyDLP
Copy link

@AndyDLP AndyDLP commented Apr 19, 2023

Description

This PR fixes the issues I reported in #158, where defining custom_attributes that included a hypen - in the name such as msDS-SupportedEncryptionTypes threw errors due to incorrect quoting of hashtable keys.

It also fixes an (unreported?) bug where if a custom_attribute was a large number (e.g. uidNumber = 7333677) it ended up being formatted with an exponent which then threw an error.

Tested successfully on Windows 10 & Alpine with terraform 1.2.7 & 1.4.2

References

#158

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@hashicorp-cla
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


adelapole seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@risingisland
Copy link

version number updated, attribute added to user

@GetSimpleCMS-CE
Copy link

version number corrected, attribute applied to user

1 similar comment
@GetSimpleCMS-CE
Copy link

version number corrected, attribute applied to user

@AndyDLP AndyDLP marked this pull request as draft February 28, 2024 14:57
@AndyDLP AndyDLP marked this pull request as ready for review February 28, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants