Add name property to set the AD object name #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmhughes
force-pushed
the
ad-user-name
branch
from
8c92392 to
a545dfe
Compare
|
|
koikonom
suggested changes
Apr 4, 2022
Comment on lines
+75
to
+79
| if u.Name != "" { | ||
| cmds = append(cmds, fmt.Sprintf("New-ADUser -Passthru -Name %q", u.Name)) | ||
| } else { | ||
| cmds = append(cmds, fmt.Sprintf("New-ADUser -Passthru -Name %q", u.Username)) | ||
| } |
There was a problem hiding this comment.
This will introduce state changes for existing users that may cause confusion. Although I understand the purpose of it we cannot make this is a breaking change that will have to wait for a major release.
We can either keep the whole PR on hold, or remove these lines and open a separate to make this change in the future.
There was a problem hiding this comment.
I'm personally OK to wait for the next major release as I've got a forked build in a container with a couple of the open PRs to use in the meantime.
bmhughes
force-pushed
the
ad-user-name
branch
from
a545dfe to
775cfe8
Compare
ThaVip3r
added a commit
to ThaVip3r/terraform-provider-ad
that referenced
this pull request
Mar 2, 2023
Add name property to set the AD object name hashicorp#130
ThaVip3r
added a commit
to ThaVip3r/terraform-provider-ad
that referenced
this pull request
Mar 2, 2023
Add name property to set the AD object name hashicorp#130
ThaVip3r
added a commit
to ThaVip3r/terraform-provider-ad
that referenced
this pull request
Mar 2, 2023
Add name property to set the AD object name hashicorp#130
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Right now the AD object name for an
ad_userresource is always set to the sAMAccountName value, add the ability to set this independently.References
Community Note