Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

Add more retries for entreprise test case #212

Merged
merged 1 commit into from
Feb 26, 2021
+5 −6
Merged

Add more retries for entreprise test case #212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions test/consul_helpers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,10 @@ func runConsulClusterTest(t *testing.T, packerBuildName string, examplesFolder s

func runConsulClusterTestWithVars(t *testing.T, packerBuildName string, examplesFolder string, packerTemplatePath string, sshUser string, terraformVarsMerge map[string]interface{}, enterpriseUrl string) {
// Uncomment any of the following to skip that section during the test
//os.Setenv("SKIP_setup_ami", "true")
//os.Setenv("SKIP_deploy", "true")
//os.Setenv("SKIP_validate", "true")
//os.Setenv("SKIP_teardown", "true")
// os.Setenv("SKIP_setup_ami", "true")
// os.Setenv("SKIP_deploy", "true")
// os.Setenv("SKIP_validate", "true")
// os.Setenv("SKIP_teardown", "true")

exampleFolder := test_structure.CopyTerraformFolderToTemp(t, REPO_ROOT, examplesFolder)

Expand Down Expand Up @@ -196,8 +196,7 @@ func checkEnterpriseInstall(t *testing.T, asgNameOutputVar string, terratestOpti
SshUserName: sshUser,
SshKeyPair: keyPair.KeyPair,
}

maxRetries := 10
maxRetries := 20
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious - is there any derivation behind this value? I must be honest though - I'm lacking context, so excuse me if the question had been discussed before!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the idea is to add more retries for the Check Enterprise Install which is failing on circleci like you can see in this comment.
BTW: we are trying to find a way to fix #209

sleepBetweenRetries := 10 * time.Second

output := retry.DoWithRetry(t, "Check Enterprise Install", maxRetries, sleepBetweenRetries, func() (string, error) {
Expand Down