This repository has been archived by the owner on Jan 25, 2023. It is now read-only.
Update agent configuration #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
brikis98
approved these changes
Jan 26, 2021
anouarchattouna
force-pushed
the
update_agent_configuration
branch
from
5180cee
to
f430584
Compare
Replaced deprecated 'ui' field by 'ui_config' object: 'https://www.consul.io/docs/agent/options\#ui-1' Added 'telemetry { disable_compat_1.9 = true }' to disable metrics deprecated in v1.9: 'https://www.consul.io/docs/agent/options\#telemetry-disable_compat_1.9'
bump 'min_packer_version' -> 1.5.4 bump 'consul_version' -> 1.9.2
|
Re-running tests... |
|
Hm, a bunch of tests just failed with errors like this: This is something new that just appeared and isn't related to this PR. I just saw it in #209 the first time, though it only happened on one test, whereas here, it happened on 5, so it suggests it's an intermittent / transient issue. @anouarchattouna Apologies for the yak shave, but would you mind digging into this issue a bit? See if you can repro by manually running |
|
There was an AWS outage yesterday which might explain the intermittent test failures we're seeing. Re-running tests now to see if it helps. |
|
Nope, we're still getting the same type of test failures 😞 So this will need more investigation. |
brikis98
approved these changes
Feb 16, 2021
|
OK, tests are now running! Not sure what the issue was last week. Perhaps some CircleCi bug? |
|
Tests passed! Merging now. |
|
I wonder if this fixed #209? |
|
(I know the tests passed, but it was an intermittent test failure, so perhaps we just got lucky? I guess we'll see if the merge to |
|
Hm, tests failed on merge to Perhaps the enterprise version intermittently fails to start? Or perhaps we just need more retries? @anouarchattouna Could you look into it? |
anouarchattouna
pushed a commit
to anouarchattouna/terraform-aws-consul
that referenced
this pull request
Feb 25, 2021
For more details see hashicorp#208 and hashicorp#209
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
min_packer_version->1.5.4consul_version->1.9.2uifield byui_configobject: https://www.consul.io/docs/agent/options\#ui-1telemetry { disable_compat_1.9 = true }to disable metrics deprecated inv1.9: https://www.consul.io/docs/agent/options\#telemetry-disable_compat_1.9