Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vagrant cloud pp config #8519

Merged
merged 1 commit into from
Dec 19, 2019
Merged

Vagrant cloud pp config #8519

merged 1 commit into from
Dec 19, 2019

Conversation

SwampDragons
Copy link
Contributor

@SwampDragons SwampDragons commented Dec 19, 2019

Most of packer uses *configs so that they can be written back to. Makes sense to enforce this for postprocessors too.

On another note, I suspect that the config for the vagrant cloud pp can be removed from state altogether if we are better about passing variables to steps. This is something that would be an easy first task for a Packer contributor.

Related: #8520

@SwampDragons SwampDragons requested a review from a team as a code owner December 19, 2019 19:26
@SwampDragons SwampDragons force-pushed the bagrant_cloud_pp_config branch from 208d186 to b23425f Compare December 19, 2019 19:27
@SwampDragons SwampDragons changed the title Bagrant cloud pp config Vagrant cloud pp config Dec 19, 2019
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I created a larger issue #8520 as a tech debt issue for updating step types to take in the needed data as opposed to relying on getting config data from the state bag.

@nywilken nywilken merged commit 0ded726 into master Dec 19, 2019
@nywilken nywilken deleted the bagrant_cloud_pp_config branch December 19, 2019 20:36
@SwampDragons SwampDragons added this to the 1.5.1 milestone Dec 20, 2019
@SwampDragons SwampDragons added post-processor/vagrant-cloud tech-debt Issues and pull requests related to addressing technical debt or improving the codebase labels Dec 20, 2019
@SwampDragons SwampDragons modified the milestones: 1.5.1, 1.5.2 Jan 7, 2020
@ghost
Copy link

ghost commented Jan 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Jan 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
post-processor/vagrant-cloud tech-debt Issues and pull requests related to addressing technical debt or improving the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants