Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update jdcloud statebag to use pointers for config, to bring in line … #8518

Merged
merged 1 commit into from
Dec 19, 2019

Conversation

SwampDragons
Copy link
Contributor

@SwampDragons SwampDragons commented Dec 19, 2019

Most of Packer uses *config when accessing configs, so that they can be written back to. for ease of maintainability, it makes sense to make this the case for all builders.

Related: #8520

Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 👍

@nywilken nywilken merged commit f45d315 into master Dec 19, 2019
@nywilken nywilken deleted the update_jdcloud_config_pointer branch December 19, 2019 20:45
@SwampDragons SwampDragons added this to the 1.5.1 milestone Dec 20, 2019
@SwampDragons SwampDragons added builder/jdcloud tech-debt Issues and pull requests related to addressing technical debt or improving the codebase labels Dec 20, 2019
@ghost
Copy link

ghost commented Jan 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Jan 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tech-debt Issues and pull requests related to addressing technical debt or improving the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants