Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPR-1537: Packer Core sends metadata to HCP Packer in UpdateBuild API #12891

Merged
merged 7 commits into from
Mar 26, 2024
Merged

HPR-1537: Packer Core sends metadata to HCP Packer in UpdateBuild API #12891

merged 7 commits into from
Mar 26, 2024

Conversation

devashish-patel
Copy link
Contributor

Description

  • Packer Core sends metadata to HCP Packer in UpdateBuild API

@devashish-patel devashish-patel self-assigned this Mar 17, 2024
lbajolet-hashicorp
lbajolet-hashicorp reviewed Mar 18, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
internal/hcp/registry/types.bucket.go Outdated Show resolved Hide resolved
internal/hcp/registry/types.bucket.go Outdated Show resolved Hide resolved
internal/hcp/registry/json.go Show resolved Hide resolved
JenGoldstrich
JenGoldstrich approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@JenGoldstrich JenGoldstrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This overall looks good to me, nice work Dev! I think we should consider refactoring the build structure here to match what the API returns, but definitely not a blocker and am curious to hear your thoughts

internal/hcp/registry/types.builds.go Outdated Show resolved Hide resolved
@devashish-patel devashish-patel marked this pull request as ready for review March 26, 2024 14:58
@devashish-patel devashish-patel requested a review from a team as a code owner March 26, 2024 14:58
@devashish-patel devashish-patel merged commit d908b3c into build-metadata-phase-1 Mar 26, 2024
6 of 11 checks passed
@devashish-patel devashish-patel deleted the HPR-1537 branch March 26, 2024 14:58
devashish-patel added a commit that referenced this pull request Apr 8, 2024
@devashish-patel
HPR-1537: Packer Core sends metadata to HCP Packer in UpdateBuild API (…
2e35c44 
…#12891)
devashish-patel added a commit that referenced this pull request Apr 8, 2024
@devashish-patel
HPR-1537: Packer Core sends metadata to HCP Packer in UpdateBuild API (…
3941708 
…#12891)
devashish-patel added a commit that referenced this pull request Apr 11, 2024
@devashish-patel
Backport Build Metadata Phase 1 Release (#12910)
4560d79 
* Packer tracks Version and Plugins Metadata (#12860)

* HPR-1537: Packer Core sends metadata to HCP Packer in UpdateBuild API (#12891)

* Use latest version of hcp-sdk-go

Remove loggers and move AddMetadataToBuild method to Version

* Update hcp-sdk-go
lbajolet-hashicorp pushed a commit that referenced this pull request Apr 11, 2024
@devashish-patel @lbajolet-hashicorp
HPR-1537: Packer Core sends metadata to HCP Packer in UpdateBuild API (…
8e92027 
…#12891)
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lbajolet-hashicorp lbajolet-hashicorp lbajolet-hashicorp left review comments

@JenGoldstrich JenGoldstrich JenGoldstrich approved these changes

Assignees

@devashish-patel devashish-patel

Labels
hcp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devashish-patel @JenGoldstrich @lbajolet-hashicorp