command: support local paths for plugins remove #12886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nywilken
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
Overall this looks good to me. I left a few suggestions.
~> packer plugin installed | xargs -n1 -I{} packer plugins remove {}
/Users/dev/.packer.d/plugins/github.com/hashicorp/amazon/packer-plugin-amazon_v1.3.1_x5.0_darwin_arm64
/Users/dev/.packer.d/plugins/github.com/hashicorp/docker/packer-plugin-docker_v1.0.9_x5.0_darwin_arm64
/Users/dev/.packer.d/plugins/github.com/hashicorp/qemu/packer-plugin-qemu_v1.0.10_x5.0_darwin_arm64
The packer plugins remove command allows users to delete plugins installed locally. Previous versions of the command only allowed for the plugins to be removed using the source for a plugin, and the versions to remove, optionally. This commit adds the capability for the plugins to be removed using their local path, in addition to the regular source+version method, that way we are able to pipe the results of `packer plugins installed' into the plugins remove command for quick plugin removal.
lbajolet-hashicorp
force-pushed
the
plugins_remove_local_path_support
branch
from
ceebd32 to
7e913c2
Compare
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The packer plugins remove command allows users to delete plugins installed locally.
Previous versions of the command only allowed for the plugins to be removed using the source for a plugin, and the versions to remove, optionally.
This commit adds the capability for the plugins to be removed using their local path, in addition to the regular source+version method, that way we are able to pipe the results of `packer plugins installed' into the plugins remove command for quick plugin removal.
Related: #12321