-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs with nomenclature changes #12795
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The contents of the docs and examples looks good. I left a few suggested changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latest changes look good to me. I left one nit but otherwise good to merge.
~> **Note:** This data source only returns the first found artifact's metadata filtered by the given options, | ||
from the returned list of artifacts associated with the specified version. Therefore, if multiple artifacts exist | ||
in the same region, it will only pick one of them. In this case, you can filter artifact by a source build name | ||
(Ex: `amazon-ebs.example`) using the `component_type` option. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍 good call out here.
This is ready to be rebased, squashed and merged into the hcp_packer_nomenclature_updates branch. |
* Update navigation bar links
19399fe
to
c973705
Compare
b06683b
into
hcp_packer_nomenclature_updates
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
No description provided.