Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs with nomenclature changes #12795

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

devashish-patel
Copy link
Contributor

No description provided.

Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The contents of the docs and examples looks good. I left a few suggested changes.

website/content/docs/hcp/index.mdx Outdated Show resolved Hide resolved
website/data/docs-nav-data.json Outdated Show resolved Hide resolved
devashish-patel

This comment was marked as off-topic.

Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest changes look good to me. I left one nit but otherwise good to merge.

~> **Note:** This data source only returns the first found artifact's metadata filtered by the given options,
from the returned list of artifacts associated with the specified version. Therefore, if multiple artifacts exist
in the same region, it will only pick one of them. In this case, you can filter artifact by a source build name
(Ex: `amazon-ebs.example`) using the `component_type` option.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍 good call out here.

@nywilken
Copy link
Contributor

This is ready to be rebased, squashed and merged into the hcp_packer_nomenclature_updates branch.

* Update navigation bar links
@nywilken nywilken merged commit b06683b into hcp_packer_nomenclature_updates Jan 23, 2024
11 of 12 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 23, 2024
@devashish-patel devashish-patel deleted the nomenclature-docs branch April 15, 2024 21:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants