Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Packer Plugin SDK to use go-cty fork #12717

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

nywilken
Copy link
Contributor

@nywilken nywilken commented Nov 28, 2023

  • Bumps github.com/hashicorp/packer-plugin-sdk from 0.4.0 to 0.5.2
  • hcl2template/functions: Add Non-null refinements for various functions

@nywilken nywilken requested a review from a team as a code owner November 28, 2023 18:02
@nywilken nywilken added the dependencies Auto-pinning label Nov 28, 2023
@nywilken nywilken changed the title deps/bump packer plugin sdk with gocty fix Bump Packer Plugin SDK to use go-cty fork Nov 28, 2023
cty's new "refinements" concept allows us to reduce the range of unknown
values from our functions. This initial changeset focuses only on
declaring which functions are guaranteed to return a non-null result,
which is a helpful baseline refinement because it allows "== null" and
"!= null" tests to produce known results even when the given value is
otherwise unknown.

This commit also includes some updates to test results that are now
refined based on cty's own built-in refinement behaviors, just as a
result of us having updated cty in the previous commit.
Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lbajolet-hashicorp lbajolet-hashicorp added the backport/1.10.x Backport PR changes to `release/1.10.x` label Nov 29, 2023
@nywilken nywilken merged commit 263821a into main Nov 29, 2023
12 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/1.10.x Backport PR changes to `release/1.10.x` dependencies Auto-pinning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants