Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: reorg plugins installation tabs #12713

Merged
merged 3 commits into from
Nov 30, 2023

Conversation

lbajolet-hashicorp
Copy link
Contributor

In order to better document packer plugins installation methods, and since `packer plugins install' is not really manual, we split in two sections the "manual installation".

In order to better document packer plugins installation methods, and
since `packer plugins install' is not really manual, we split in two
sections the "manual installation".

As this is legacy, we stop documenting how to install single-component
plugins, and reword the documentation for manually installing a plugin.
This section is redundant with the explanations given above, and can
therefore be removed from the docs.
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

The current documentation about installing plugins does not explain
(outside of the `packer init' section) how Packer discovers plugins,
what the expected file system hierarchy should be, and the quirk of how
this takes precedence over the rest when `required_plugins' is
specified.

This commit addresses that by reorganising the page to highlight general
usage questions on sources and plugins, and simplifies the tabs below to
only highlight installation methods.
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@lbajolet-hashicorp lbajolet-hashicorp merged commit 24430e2 into main Nov 30, 2023
13 checks passed
@lbajolet-hashicorp lbajolet-hashicorp added the backport/website Backport PR changes to `stable-website` and latest release branch label Nov 30, 2023
@lbajolet-hashicorp lbajolet-hashicorp deleted the plugin_install_doc_updates branch November 30, 2023 14:44
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/website Backport PR changes to `stable-website` and latest release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants