Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts/prepare_changelog: Replace python for with gh and jq commands #12689

Merged
merged 1 commit into from
Nov 9, 2023
Merged

scripts/prepare_changelog: Replace python for with gh and jq commands #12689

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 19 additions & 45 deletions scripts/prepare_changelog.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,78 +4,52 @@


LAST_RELEASE=$1
DO_PR_CHECK=1

nywilken marked this conversation as resolved.
Show resolved Hide resolved
set -o pipefail

is_doc_or_tech_debt_pr(){
if ! (($+commands[jq])); then
DO_PR_CHECK=0
echo "jq not found"
return 1
fi
out=$(python3 -m json.tool < pull.json \
| jq '[.labels[].name == "docs" or .labels[].name == "tech-debt" or .labels[].name == "website"] | any')
grep -q true <<< $out
return $?
}

if [ -z $LAST_RELEASE ]; then
echo "you need to give the previous release version. prepare_changelog.sh v<version>"
exit 1
fi

if [ -z "$(which jq)" ]; then
echo "jq command not found"
return 1
fi

if [ -z "$(which jq)" ]; then
echo "gh command not found"
return 1
fi

get_prs(){
# git log v0.10.2...c3861d167533fb797b0fae0c380806625712e5f7 |
git log HEAD...${LAST_RELEASE} --first-parent --oneline --grep="Merge pull request #[0-9]\+" --grep="(#[0-9]\+)$" |
grep -o "#\([0-9]\+\)" | awk -F\# '{print $2}' | while read line
release_time="$(gh release view --json "createdAt" --jq '.createdAt' ${LAST_RELEASE})"
gh pr list -s merged -S "merged:>=$release_time -label:documentation -label:automated -label:tech-debt -label:website -label:legal -label:docs -author:hc-github-team-packer" --json "number" --jq '.[]|.number' \
| while read line
do
grep -q "GH-${line}" CHANGELOG.md
if [ $? -ne 0 ]; then
if grep -q "GH-${line}" CHANGELOG.md; then
echo $line
fi
done | while read PR_NUM
do
if [[ -z "${GITHUB_TOKEN}" ]] || [[ -z "${GITHUB_USERNAME}" ]] ; then
out=$(curl -fsS "https://api.github.com/repos/hashicorp/packer/issues/${PR_NUM}" -o pull.json)
else
# authenticated call
out=$(curl -u ${GITHUB_USERNAME}:${GITHUB_TOKEN} -fsS "https://api.github.com/repos/hashicorp/packer/issues/${PR_NUM}" -o pull.json)
fi
exy="$?"
if [ $exy -ne 0 ]; then
out=$(gh pr view ${PR_NUM} --json "title,labels,url" > pull.json)
if [ "$?" -ne 0 ]; then
echo "bad response from github: manually check PR ${PR_NUM}"
continue
fi

if (($DO_PR_CHECK)) && is_doc_or_tech_debt_pr; then
echo "Skipping PR ${PR_NUM}: labeled as tech debt, docs or website. (waiting a second so we don't get rate-limited...)"
continue
fi
echo "$(python3 -m json.tool < pull.json | jq -r '.title') - [GH-${PR_NUM}](https://github.com/hashicorp/packer/pull/${PR_NUM})"
echo "$(jq -r '.title' < pull.json) - [GH-${PR_NUM}](https://github.com/hashicorp/packer/pull/${PR_NUM})"
rm -f pull.json
done
}

#is_doc_or_tech_debt_pr 52061111
# is_doc_or_tech_debt_pr 5206 # non-doc pr
#is_doc_or_tech_debt_pr 5434 # doc pr
#echo $?
#exit

# prpid=$!
# trap 'kill -9 ${prpid}; exit' INT TERM

get_prs | while read line; do
echo $line
if [[ "$line" =~ "bad" ]]; then
exit 1
elif [[ "$line" =~ "Skipping" ]]; then
sleep 1 # GH will rate limit us if we have several in a row
continue
fi
rm -f pull.json
echo "Press enter to continue with next entry.."
vared -ch ok
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That command's a total mystery to me, what's vared?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a zsh function that drops zsh into a temp editor. The value typed in before hitting return will be assigned to the value ok. It looks like this is being used as a way to make the command interactive. Otherwise it just prints all the line entries.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made one change to it for now.

done


#TODO: just generate it automatically using PR titles and tags