Add path attribute to required plugins #12641
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The required_plugins parse tests define a `want_diags' flag, but don't actually use it in subtests, so if one was to add a test that is expected to produce errors on this step, this would always fail.
In order to let users circumvent the plugin loading mechanisms for loading plugins specified in the `required_plugins' blocks, we add a new `path' attribute to the plugin specifiers. Specifying this attribute makes it so that loading the plugin circumvents completely the checks in place for a required plugin (version, source), and forcefully loads the plugin from the specified path. That being said, this is not a reliable long-term solution for this kind of problem, as it makes it harder/impossible to share the template, as the path must resolve in order for the build to proceed, and this is environment-bound.
|
Note: this is reviewable as-is, but we should probably wait until I write more tests for it, I'm not sure how to proceed because of the plugins' dependency, but I'll figure it out |
nywilken
added
enhancement
stage/needs-discussion
stage/thinking
|
Closing in favor of #12643 - but keeping the branch around for historical purposes should we need to revisit. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.