refactor: use ui.Sayf and ui.Errorf
#444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbajolet-hashicorp
approved these changes
Jun 19, 2024
There was a problem hiding this comment.
LGTM, thanks for this update @tenthirtyam!
I left a small nit, let me know what you want to do with it, and we can merge after that
tenthirtyam
force-pushed
the
refactor/uiSay-uiError
branch
from
228ec9e to
1960882
Compare
tenthirtyam
force-pushed
the
refactor/uiSay-uiError
branch
from
1960882 to
4b9e8c1
Compare
Updated `packer-plugin-sdk` to v0.5.4. Updated instances of the following to take advantage of changes in `packer-plugin-sdk` v0.5.3 and later. - `ui.Say(fmt.Errorf(` to `ui.Sayf(` - `ui.Error(fmt.Errorf(` to `ui.Errorf(` Updates messaging to be more consistent, where applicable. Signed-off-by: Ryan Johnson <[email protected]>
lbajolet-hashicorp
force-pushed
the
refactor/uiSay-uiError
branch
from
4b9e8c1 to
6c3ba37
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated
packer-plugin-sdkto v0.5.4.Updated instances of the following to take advantage of changes in
packer-plugin-sdkv0.5.3 and later.ui.Say(fmt.Errorf(toui.Sayf(ui.Error(fmt.Errorf(toui.Errorf(Updates messaging to be more consistent, where applicable.
Testing
Reference
hashicorp/packer-plugin-sdk#225