Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.goreleaser.yml: Update configuration to v2 #252

Merged
merged 1 commit into from
Jun 18, 2024
Merged

.goreleaser.yml: Update configuration to v2 #252

merged 1 commit into from
Jun 18, 2024

Conversation

nywilken
Copy link
Contributor 

~>  goreleaser -v
GitVersion:    2.0.1

~>  goreleaser check
  • checking                                 path=.goreleaser.yml
  • 1 configuration file(s) validated
  • thanks for using goreleaser!

.goreleaser.yml: Update configuration to v2
3454dc9 
```
~>  goreleaser -v
GitVersion:    2.0.1

~>  goreleaser check
  • checking                                 path=.goreleaser.yml
  • 1 configuration file(s) validated
  • thanks for using goreleaser!

```
@nywilken nywilken requested a review from a team as a code owner June 18, 2024 16:51
@nywilken nywilken added the tech-debt Issues and pull requests related to addressing technical debt or improving the codebase label Jun 18, 2024
JenGoldstrich
JenGoldstrich approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@JenGoldstrich JenGoldstrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than extranaeous - in yaml

.goreleaser.yml
build:
skip: true
builds:
-
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the change to line 7 needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah builds is an array.

@nywilken nywilken merged commit 6d1148a into main Jun 18, 2024
9 checks passed
@lbajolet-hashicorp lbajolet-hashicorp deleted the nywilken.update-goreleaser-v2 branch June 18, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JenGoldstrich JenGoldstrich JenGoldstrich approved these changes

Assignees
No one assigned
Labels
tech-debt Issues and pull requests related to addressing technical debt or improving the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nywilken @JenGoldstrich