Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump vault api dependancy to mitigate go-jose concerns, removes support for go1.20 #247

Merged
merged 4 commits into from
Jun 14, 2024

Conversation

JenGoldstrich
Copy link
Contributor

@JenGoldstrich JenGoldstrich commented Jun 13, 2024

I ran go get github.com/hashicorp/vault/api to mitigate concerns from Azure Plugin consumers with go-jose vulns, I understand these are not impacting the SDK directly but its worth an easy fix

go-jose v4 supports go 1.21 as the minimum version.

@JenGoldstrich JenGoldstrich requested a review from a team as a code owner June 13, 2024 18:48
@JenGoldstrich JenGoldstrich changed the title Bump vault api dependancy to mitigate go-jose concerns Bump vault api dependancy to mitigate go-jose concerns, removes support for go1.20 Jun 13, 2024
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nywilken nywilken merged commit 4d66cfc into main Jun 14, 2024
9 checks passed
@nywilken nywilken deleted the bump_vault_dependancy branch June 14, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants