Add instance_id to state so ID is usable in provisioners #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
|
Hi @vheon, From a quick glance at the code, this looks OK to me! For testing, when you build the plugin, it will output a binary, which can then be loaded by Packer according to the rules specfied in this documentation section. By any chance, could you share your template so we can help? Also FYI, before we can merge this PR, we'll need you to sign our CLA first. This is not a pressing matter as we still need to ensure this works as expected, but please be aware this is required by our legal department for external contributions. Thanks, and please let us know if we can help further! |
|
Looking at the documentation I thought that I could simply build the plugin and copy it in the directory where I ran
packer {
required_plugins {
lxd = {
version = ">= 1.0.1"
source = "github.com/hashicorp/lxd"
}
ansible = {
source = "github.com/hashicorp/ansible"
version = "~> 1"
}
}
}
source "lxd" "centos7" {
image = "images:centos/7"
}
build {
name = "test"
source "lxd.centos7" {
output_image = "test-image"
publish_properties = {
description = "Make with Packer"
}
}
provisioner "ansible" {
playbook_file = "./playbooks/main.yml"
user = "root"
extra_arguments = [ "--extra-vars", "ansible_host=${build.ID} ansible_connection=${source.type}" ]
ansible_env_vars = ["ANSIBLE_FORCE_COLOR=1"]
}
}and ---
- name: Test play
hosts: all
gather_facts: false
tasks:
- name: Test
ansible.builtin.ping:the output of Looking at the log it doesn't seems to pick up the plugin in the current directory. Any help would be appreciated. |
|
Hey @vheon, Sounds on point, you're running into this behaviour: "Where applicable, some installation processes such as packer init may override the plugin loading process." To be fair, we think this is confusing, and are re-thinking our process for installing/loading plugins from Packer, please refer to this issue on Packer for information. If you have an opinion on this subject, please don't hesitate to share it in this issue! For your case, if you want to be able to load the plugin, there's essentially two choices at the moment:
Hope that helps! |
|
@vheon the changes look good but we need you to sign the CLA before we can approve and merge. |
|
Hi there 👋, I'm going to close this pull-request since there hasn't been any updates to it since the last request for the CLA. But if you are still interested in seeing this change please feel free to leave a comment after the signing the CLA we will gladly reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The change I'm proposing should be pretty straightforward but I'm having difficulty testing it as
packeris not picking up my locally built plugin and keep using the "official" one. Also the content of the linked CONTRIBUTING.md file seems sort of not updated.https://github.com/hashicorp/packer-plugin-lxd/blob/main/.github/CONTRIBUTING.md#opening-an-pull-request
Any pointers would be welcome on this 🙏