Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prometheus: Added support for dns in network and persistent volumes #127

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Rendanic
Copy link
Contributor

@Rendanic Rendanic commented May 1, 2022

This is a breaking change when prometheus_group_network has been
modified, due to chnaged structure in
prometheus_group_network. See new default for changes:

mode  = "bridge",
ports = {
  "http" = 9090,
},
dns = {}

Please confirm the following if submitting a new pack:

New Pack Checklist

  • The README includes any information necessary to run the application that is not encoded in the pack itself.
  • The pack renders properly with nomad-pack render <NAME>
  • The pack plans properly with nomad-pack plan <NAME>
  • The pack runs properly with nomad-pack runs <NAME>
  • If applicable, a screenshot of the running application is attached to the PR.
  • The default variable values result in a syntactically valid pack.
  • Non-default variables values have been tested. Conditional code paths in the template have been tested, and confirmed to render/plan properly.
  • If applicable, the pack includes constraints necessary to run the pack safely (I.E. a linux-only constraint for applications that require linux).

This is a breaking change when prometheus_group_network has been
modified, due to chnaged structure in
prometheus_group_network. See new default for changes:

mode  = "bridge",
ports = {
  "http" = 9090,
},
dns = {}
@Rendanic Rendanic force-pushed the pr-prometheus-1 branch from 9102c12 to f6e6ac7 Compare May 1, 2022 17:11
@Rendanic Rendanic marked this pull request as ready for review May 1, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant