Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Issues with codecov upload #2684

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Conversation

san-est
Copy link
Contributor

@san-est san-est commented Dec 2, 2024

Description:

This PR aims to roll-back codecov upload action to an older more stable version. Once issues are resolved in latest version we can re-update.

Related issue(s):

Fixes #2683

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@san-est san-est added the github_actions Pull requests that update GitHub Actions code label Dec 2, 2024
@san-est san-est added this to the v2.55.0 milestone Dec 2, 2024
@san-est san-est self-assigned this Dec 2, 2024
@san-est san-est requested review from a team as code owners December 2, 2024 09:25
@san-est san-est linked an issue Dec 2, 2024 that may be closed by this pull request
@san-est san-est changed the title 2683 ci issues with codecov upload ci:issues with codecov upload Dec 2, 2024
Copy link

sonarcloud bot commented Dec 2, 2024

@san-est san-est changed the title ci:issues with codecov upload ci: Issues with codecov upload Dec 2, 2024
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.41%. Comparing base (c3db586) to head (213adc2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2684   +/-   ##
=======================================
  Coverage   85.40%   85.41%           
=======================================
  Files         285      285           
  Lines       71500    71500           
=======================================
+ Hits        61064    61069    +5     
+ Misses      10436    10431    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mishomihov00 mishomihov00 merged commit 0fb8903 into main Dec 3, 2024
9 checks passed
@mishomihov00 mishomihov00 deleted the 2683-ci-issues-with-codecov-upload branch December 3, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: Issues with codecov upload
4 participants