Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump com.esaulpaugh:headlong from 12.1.0 to 12.3.3 in /sdk-dependency-versions #2059

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 4, 2024

Bumps com.esaulpaugh:headlong from 12.1.0 to 12.3.3.

Release notes

Sourced from com.esaulpaugh:headlong's releases.

v12.3.3 (update)

fix parseTupleType should be private; reduce max decoded offset to 2^30 - 1;

SHA-256 (headlong-12.3.3.jar): 9b577af538d30ffc05133425c8b0bff3a79bcba99955b3222dd2d825b27150cc

Full Changelog: esaulpaugh/headlong@v12.3.2...v12.3.3

v12.3.2 (update)

add method ABIJSON.parseABIField; minor optimizations;

SHA-256 (headlong-12.3.2.jar): 139359dbd4d8b286e93e06433db903acd9a9c0fc46f15df112040cb25379f342

Full Changelog: esaulpaugh/headlong@v12.3.1...v12.3.2

v12.3.1 (update)

What's Changed

SHA-256 (headlong-12.3.1.jar): c2cf0735de80c6da56fdecc3dcec4d3a05e851fe40626eda1a93040e59a5477e

Full Changelog: esaulpaugh/headlong@v12.3.0...v12.3.1

v12.3.0 (change to module name, update)

change module name to com.esaulpaugh.headlong; downgrade gson to v2.10.1; remove TupleType#getNonCapturing, TypeFactory.createNonCapturing; remove no-args Tuple.of(); add stream and iterator methods to ABIJSON; reinstate Tuple.singleton; make validate generic; make SuperSerial methods generic; improve asArrayType signature; rename some type params; improve javadoc; performance improvements;

SHA-256 (headlong-12.3.0.jar): 446daf0f5a616a54ac85fb28f9ef240394471ff34fc89d4b21e939965b5b5962

Full Changelog: esaulpaugh/headlong@v12.2.0...v12.3.0

v12.2.0 (update)

disallow JsonNull for boolean fields; reset ByteBuffer position before returning from Strings.encode;

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested review from a team as code owners November 4, 2024 05:42
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Nov 4, 2024
@dependabot dependabot bot requested a review from dalvizu November 4, 2024 05:42
@dependabot dependabot bot requested a review from rbarkerSL November 4, 2024 05:42
rbarkerSL
rbarkerSL previously approved these changes Nov 4, 2024
@rbarkerSL rbarkerSL dismissed their stale review November 4, 2024 06:57

Don't like that the build check fails with this version of headlong

@mishomihov00
Copy link
Contributor

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/gradle/sdk-dependency-versions/com.esaulpaugh-headlong-12.3.3 branch from a4672b4 to f16360d Compare November 5, 2024 12:50
@san-est
Copy link

san-est commented Nov 11, 2024

@dependabot rebase

Bumps [com.esaulpaugh:headlong](https://github.com/esaulpaugh/headlong) from 12.1.0 to 12.3.3.
- [Release notes](https://github.com/esaulpaugh/headlong/releases)
- [Commits](esaulpaugh/headlong@v12.1.0...v12.3.3)

---
updated-dependencies:
- dependency-name: com.esaulpaugh:headlong
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/gradle/sdk-dependency-versions/com.esaulpaugh-headlong-12.3.3 branch from f16360d to d541ac0 Compare November 11, 2024 12:51
@rbarkerSL
Copy link
Contributor

@mishomihov00 want to look into why dependabot updates are breaking sdj java?

@mishomihov00 mishomihov00 self-assigned this Nov 19, 2024
@mishomihov00
Copy link
Contributor

@jjohannes Could you please take a look at why is this failing. The problem seems to be coming from this commit in the headlong repo, but I'm not sure how to fix it - esaulpaugh/headlong@0a63986#diff-49a96e7eea8a94af862798a45174e6ac43eb4f8b4bd40759b5da63ba31ec3ef7R55

Tried a few different ways, but none of them are working.

@jjohannes
Copy link
Contributor

@mishomihov00 We have some dependencies that are not prepared to be used with the Java Module System (JPMS). headlong is/was one of them.

In JPMS, each module has a unique Module Name. If that does not exist, we need to make one up. We just called it headlong here.

With this update, headlong gets an official name, which is com.esaulpaugh.headlong. We should respect the official name and that is why the build is failing. I pushed a commit to this branch that corrects the name.

@jjohannes jjohannes force-pushed the dependabot/gradle/sdk-dependency-versions/com.esaulpaugh-headlong-12.3.3 branch from 00ecde5 to b865969 Compare November 20, 2024 13:07
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.64%. Comparing base (b86ee46) to head (b865969).
Report is 162 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2059      +/-   ##
============================================
+ Coverage     82.20%   82.64%   +0.44%     
- Complexity     3588     3932     +344     
============================================
  Files           186      199      +13     
  Lines         11697    12729    +1032     
  Branches       1150     1253     +103     
============================================
+ Hits           9615    10520     +905     
- Misses         1604     1711     +107     
- Partials        478      498      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@0xivanov 0xivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xivanov 0xivanov merged commit c8a5604 into main Nov 20, 2024
13 checks passed
@0xivanov 0xivanov deleted the dependabot/gradle/sdk-dependency-versions/com.esaulpaugh-headlong-12.3.3 branch November 20, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants