Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added cache refreshing after subsequent getFilterLogs calls for the same filter #3308

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

simzzz
Copy link
Contributor

@simzzz simzzz commented Dec 5, 2024

Description:

During debugging of #3030 an inconsistency was found where we automatically refresh the TTL for our filter cache entries for getFilterChanges but not for getFilterLogs. This PR solves this inconsistency.

Related issue(s):
#3030
Fixes #3311

Notes for reviewer:

Checklist

  • Tested (unit, integration, etc.)

@simzzz simzzz requested review from AlfredoG87, lukelee-sl and a team as code owners December 5, 2024 08:34
Copy link

sonarqubecloud bot commented Dec 5, 2024

@nadezhdapopovaa nadezhdapopovaa added the bug Something isn't working label Dec 5, 2024
@nadezhdapopovaa nadezhdapopovaa added this to the 0.62.0 milestone Dec 5, 2024
@simzzz simzzz changed the title fix: we now refresh the cache after getFilterLogs calls as well fix: added cache refreshing after subsequent getFilterLogs calls for the same filter Dec 5, 2024
Copy link
Member

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@konstantinabl konstantinabl merged commit cbcc55d into hashgraph:main Dec 6, 2024
41 of 46 checks passed
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 43.28%. Comparing base (af2159f) to head (85782a8).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
.../lib/services/ethService/ethFilterService/index.ts 40.00% 3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (af2159f) and HEAD (85782a8). Click for more details.

HEAD has 18 uploads less than BASE
Flag BASE (af2159f) HEAD (85782a8)
config-service 1 0
relay 1 0
17 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3308       +/-   ##
===========================================
- Coverage   84.98%   43.28%   -41.71%     
===========================================
  Files          65       65               
  Lines        4456     4431       -25     
  Branches     1014     1014               
===========================================
- Hits         3787     1918     -1869     
- Misses        331     2156     +1825     
- Partials      338      357       +19     
Flag Coverage Δ
config-service ?
relay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../lib/services/ethService/ethFilterService/index.ts 15.21% <40.00%> (-67.01%) ⬇️

... and 46 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cache doesn't get refreshed after subsequent calls to getFilterLogs
4 participants