fix: let 0 value transactions pass #3304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simeon Nakov <[email protected]>
simzzz
requested review from
AlfredoG87,
lukelee-sl and
a team
as code owners
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
victor-yanev
requested changes
Nov 28, 2024
Signed-off-by: Simeon Nakov <[email protected]>
nadezhdapopovaa
previously approved these changes
Nov 29, 2024
victor-yanev
requested changes
Nov 29, 2024
Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
victor-yanev
previously approved these changes
Nov 29, 2024
nadezhdapopovaa
previously approved these changes
Dec 2, 2024
Co-authored-by: Nana Essilfie-Conduah <[email protected]> Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
|
nadezhdapopovaa
approved these changes
Dec 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3304 +/- ##
===========================================
+ Coverage 78.88% 98.14% +19.26%
===========================================
Files 48 4 -44
Lines 3608 54 -3554
Branches 841 10 -831
===========================================
- Hits 2846 53 -2793
+ Misses 423 0 -423
+ Partials 339 1 -338
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes the case where transactions with a value of 0 would not pass. This is needed because they would pass as valid transactions on the Ethereum network as 0 is a valid value there.
Related issue(s):
Fixes #3105
Notes for reviewer:
Checklist