chore: cherry picked 2487 #2518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ture in ws server (#2474) (#2487) * feat: added shouldRateLimitOnMethod() to connectionLimiter Signed-off-by: Logan Nguyen <[email protected]> * feat: applied shouldRateLimitOnMethod() on batch requests Signed-off-by: Logan Nguyen <[email protected]> * feat: applied shouldRateLimitOnMethod() on single requests Signed-off-by: Logan Nguyen <[email protected]> * feat: added methodsCounter metric for batch_requests Signed-off-by: Logan Nguyen <[email protected]> * fix: skipped rateLimit for eth_subscribe and eth_unsubscribe Signed-off-by: Logan Nguyen <[email protected]> * test: added acceptancetest for rate limiter in the WS Signed-off-by: Logan Nguyen <[email protected]> * test: enabled test_ws_server in ratelimiter CI Signed-off-by: Logan Nguyen <[email protected]> --------- Signed-off-by: Logan Nguyen <[email protected]>
quiet-node
requested review from
AlfredoG87,
ebadiere,
georgi-l95,
Ivo-Yankov,
a team and
Nana-EC
as code owners
|
ebadiere
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Cherry picked #2487
Related issue(s):
Fixes #
Notes for reviewer:
Checklist